Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull requests try to perform git clean -dff in incorrect places for submodules, causing it to fail to clone #180

Open
Neko-Box-Coder opened this issue Sep 2, 2024 · 0 comments

Comments

@Neko-Box-Coder
Copy link

Plugin Version: 1.4.0-RC4

Error:

    Modification check failed for material: [url=https://github.com/Neko-Box-Coder/runcpp2.git]
    Affected pipelines are runcpp2PR_Trigger.02 Sep, 2024 at 22:51:40 Local Time

The plugin sent a response that could not be understood by Go. Plugin returned with code '500' and the following response: 

'"Exception (/go-working-dir/pipelines/flyweight/00200c68-09ed-4703-9ff4-4f28ad23b094/ssLogger doesn\u0027t exist.) 

Occurred: [git, clean, -dff] - /go-working-dir/pipelines/flyweight/00200c68-09ed-4703-9ff4-4f28ad23b094/ssLogger"'

Judging from the error, it seems like it is trying to do git clean -dff on one of my submodules or something. When I go to the folder (/go-working-dir/pipelines/flyweight/00200c68-09ed-4703-9ff4-4f28ad23b094), ssLogger (one of my submodules) is not in that folder, instead it is in the External folder where I put all my submodules in.

Here's my .gitmodules file

...
[submodule "ssLogger"]
	path = External/ssLogger
	url = https://github.com/Neko-Box-Coder/ssLogger.git

My guess is it is trying to perform git clean -dff based on the title of the submodule instead of the path, causing it to fail.

I have 8+ submodules where the path is different from their name in the submodule file, changing them would be a bit of a chore.

It seems like the normal material can clone it without a problem though, so I am not sure what this plugin is doing wrong here.

It would be great if this can get addressed, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant