Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for esphome 2023.12.x #4

Open
wants to merge 1 commit into
base: lilygo-t5-47
Choose a base branch
from

Conversation

daernsinstantfortress
Copy link

What does this implement/fix?

Fixes some compatibility issues introduced with changes in ESPHome 2023.12.0

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

Copy link
Author

@daernsinstantfortress daernsinstantfortress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the last release of ESPHome, some small changes were done to the display
component, to make subcomponents leaner. With those changes, compilation breaks
if a display is trying to register as a component itself (this is now done
automatically when registering the display).

Also, DisplayBuffer now automatically inherits from PollingComponent, so there is no need to explicitly inherit from that.

@hagak
Copy link

hagak commented Feb 17, 2024

I attempted to use your fork @daernsinstantfortress . However this fails against esphome 2023.12.9, reason is in 2023.12.9 the DisplayBufferRet no longer exists.

@daernsinstantfortress
Copy link
Author

@hagak Someone else reported something similar, but I've just retested as a clean build against my own 2023.12.9 install and it built ok using this:

external_components:
  - source: github://daernsinstantfortress/esphome-lilygo-t5-47@lilygo-t5-47
    components:
      - lilygo_t5_47

...so I can't explain the mismatch in behaviour here.

@hagak
Copy link

hagak commented Feb 17, 2024

Well I mean if you go and look at esphome/esphome display component the DisplayBufferRet does not exist anymore. Maybe you have building against an older version? I know the fork you have is a pretty old fork of esphome and is not 2023.12.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants