-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API call functions don't have timeouts #26
Comments
The problem seems to occur in all functions that do API calls to the switch. I have located the problem in Lines 356 to 362 in aa91f08
There's no connection or read timeout set here. Changing this to return operations[operation](
self._build_uri(path),
verify=verify,
params=params,
data=data,
proxies=self.proxy,
timeout=(5,30)
) seems to fix the problem (the timeout is set to 5, the read timeout to 30 seconds). |
Can you change this so it can be changed from an ansible variable in playbook maybe ? I've hade issues with timeouts when set to 5 sec on some jobs. |
We do not use pyaoscx within Ansible, we're using it in our own python tools. 5s was just a suggestion. This could be set to any other reasonable value as long as there is a timeout at all. You could implement this to have a default timeout which can be overridden by software that uses pyaoscx like Ansible. |
...
EDIT: I located the problem, see next post.
The text was updated successfully, but these errors were encountered: