Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nestjs): Allow NestJS v11 as peerDependency #3042

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

blaine-arcjet
Copy link
Contributor

@blaine-arcjet blaine-arcjet commented Jan 31, 2025

This updates our NestJS adapter to support NestJS v11 as a peerDependency.

I reviewed the breaking changes and they are mostly user-facing. We wrote our own metadata merging function so we didn't even have to change that.

Closes #2921

Copy link

trunk-io bot commented Jan 31, 2025

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

Copy link

socket-security bot commented Jan 31, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@nestjs/[email protected] 🔁 npm/@nestjs/[email protected] None +6 494 kB nestjscore
npm/@nestjs/[email protected] 🔁 npm/@nestjs/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +177 32.9 MB kamilmysliwiec, nestjscore
npm/@nestjs/[email protected] 🔁 npm/@nestjs/[email protected], npm/@nestjs/[email protected] None +3 539 kB nestjscore
npm/@nestjs/[email protected] 🔁 npm/@nestjs/[email protected] None +3 1.56 MB nestjscore
npm/@nestjs/[email protected] 🔁 npm/@nestjs/[email protected] Transitive: environment, filesystem, shell +7 1.06 MB nestjscore
npm/@nestjs/[email protected] 🔁 npm/@nestjs/[email protected] Transitive: environment, eval, network +17 2.32 MB nestjscore
npm/@nestjs/[email protected] 🔁 npm/@nestjs/[email protected] Transitive: environment, eval, filesystem, network, unsafe +88 3.26 MB kamilmysliwiec, nestjscore
npm/@nestjs/[email protected] 🔁 npm/@nestjs/[email protected] Transitive: environment, eval, filesystem +41 6.17 MB nestjscore
npm/@nestjs/[email protected] 🔁 npm/@nestjs/[email protected] Transitive: environment, eval, filesystem, network, unsafe +36 3.69 MB nestjscore
npm/@types/[email protected] None 0 2.22 MB types
npm/[email protected] 🔁 npm/[email protected] Transitive: environment +8 634 kB bpscott, jounqin, lydell, ...3 more

🚮 Removed packages: npm/@launchdarkly/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected]

View full report↗︎

Copy link

socket-security bot commented Jan 31, 2025

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
New author npm/@fastify/[email protected] 🚫
New author npm/[email protected] 🚫
Unstable ownership npm/[email protected] 🚫
License Policy Violation npm/[email protected]
  • License: CC-BY-4.0 - Not allowed by license policy (npm metadata, package/LICENSE, package/package.json)
⚠︎
New author npm/@fastify/[email protected] 🚫
Unstable ownership npm/@fastify/[email protected] 🚫
New author npm/@fastify/[email protected] 🚫
Unstable ownership npm/@fastify/[email protected] 🚫
New author npm/[email protected] 🚫
Unstable ownership npm/[email protected] 🚫
New author npm/@fastify/[email protected] 🚫
Unstable ownership npm/@fastify/[email protected] 🚫
New author npm/@fastify/[email protected] 🚫
Unstable ownership npm/@fastify/[email protected] 🚫
New author npm/@fastify/[email protected] 🚫
Unstable ownership npm/@fastify/[email protected] 🚫
New author npm/[email protected] 🚫
Unstable ownership npm/[email protected] 🚫
New author npm/[email protected] 🚫
Unstable ownership npm/[email protected] 🚫

Ignoring: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/@nuxt/[email protected], npm/[email protected]

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is unstable ownership?

A new collaborator has begun publishing package versions. Package stability and security risk may be elevated.

Try to reduce the number of authors you depend on to reduce the risk to malicious actors gaining access to your supply chain. Packages should remove inactive collaborators with publishing rights from packages on npm.

What is a license policy violation?

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

"@angular-devkit/schematics-cli": "19.1.3",
"@inquirer/prompts": "7.2.3",
"@nestjs/schematics": "11.0.0",
"ansis": "3.9.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like that Nest switched to this - the author has the patterns of an author I wouldn't trust. It's just in our examples so I guess we have to accept it.

@blaine-arcjet
Copy link
Contributor Author

@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/@nuxt/[email protected]

@blaine-arcjet blaine-arcjet marked this pull request as ready for review January 31, 2025 23:21
@blaine-arcjet blaine-arcjet requested a review from a team as a code owner January 31, 2025 23:21
@blaine-arcjet
Copy link
Contributor Author

It seems like we didn't need any changes 💪 All of the examples worked when upgraded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review NestJS 11 changes
2 participants