Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): parallelize update workflow #102

Closed
wants to merge 15 commits into from
Closed

chore(ci): parallelize update workflow #102

wants to merge 15 commits into from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Sep 4, 2021

Hi @knqyf263, this is an attemps to shorten update workflow duration.

What do you think ?

Fixes #101

NB: squash commits instead of merge

@mmorel-35 mmorel-35 marked this pull request as draft September 4, 2021 19:58
@mmorel-35 mmorel-35 marked this pull request as ready for review September 4, 2021 20:16
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vuln-list-update pushes commits to vuln-list. If we do these updates in parallel, they will be conflicted.

@mmorel-35
Copy link
Contributor Author

I see, so what it needs is a kind of map reduce system. The retrieving of the content is parallel but the persistence happens only once.

@knqyf263
Copy link
Collaborator

knqyf263 commented Sep 5, 2021

Exactly.

@mmorel-35
Copy link
Contributor Author

Ok, so I drop this PR. It can be reopen when the projet is map reduce compatible.

@mmorel-35 mmorel-35 closed this Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor : Update vuln-list repo
2 participants