Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mysql and sqlite #34

Open
apstanisic opened this issue Feb 16, 2023 · 4 comments
Open

Enable mysql and sqlite #34

apstanisic opened this issue Feb 16, 2023 · 4 comments
Labels
enhancement New feature or request priority-low Low priority

Comments

@apstanisic
Copy link
Owner

SQLite would make it easier to start new project without docker.
There is good enough coverage that most of the things should work. I think only getting composite unique key is pg specific, and that can be easily ported.

@apstanisic apstanisic added the enhancement New feature or request label Feb 16, 2023
@apstanisic
Copy link
Owner Author

SQLite complicates by treating dates as normal text. So there are 5 different types. Knex uses integer, (maybe it's temporary bug), sequelize uses custom format, CURRENT_TIMESTEMP returns without ms, it's a mess

@apstanisic
Copy link
Owner Author

Maybe simplest solution is to check value when reading. This is done in sequelize, that I have to fix, since I think it does not support CURRENT_TIMESTAMP. Instead of new date, I can use knex.fn.now, maybe?

@apstanisic
Copy link
Owner Author

apstanisic commented Feb 18, 2023

If I want sqlite support, I certainly have to remove knex, since it's causing a lot of problems having 2 connections. And some weird behavior with transactions, it says it's busy. No problem in pg

@apstanisic
Copy link
Owner Author

It also means converting migrations from JSONB to JSON

@apstanisic apstanisic transferred this issue from another repository Mar 2, 2023
@apstanisic apstanisic transferred this issue from another repository Mar 2, 2023
@apstanisic apstanisic added the priority-low Low priority label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-low Low priority
Projects
None yet
Development

No branches or pull requests

1 participant