Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support mutiple top N merging function in MQE #12915

Closed
2 of 3 tasks
wu-sheng opened this issue Dec 31, 2024 · 0 comments · Fixed by #12937
Closed
2 of 3 tasks

[Feature] Support mutiple top N merging function in MQE #12915

wu-sheng opened this issue Dec 31, 2024 · 0 comments · Fixed by #12937
Assignees
@wankai123
Labels
backend OAP backend related. feature New feature
Milestone
10.2.0

Comments

@wu-sheng
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

As the difference between MAL and OAL, some metrics would be separated, e.g. service cpm and k8s service cpm. On the query and/or alerting MQE setup, we may need a single expression for those metrics.
So, I propose this function, top_n_of(exp1, exp2, ...)

Use case

Support to provide unified top N for multiple metric expressions. Note, the expression should keep the precious of those expressions same. Otherwise, top N would be incorrect.

Related issues

No response

Are you willing to submit a pull request to implement this on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wankai123 wankai123

Labels
backend OAP backend related. feature New feature
Projects
None yet
Milestone
10.2.0
Development

Successfully merging a pull request may close this issue.

MQE: Support top_n_of function for merging multiple metrics topn query. wankai123/skywalking
2 participants
@wu-sheng @wankai123