Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][client]Fix status html endpoint #23814

Closed
wants to merge 6 commits into from

Conversation

yunmaoQu
Copy link

@yunmaoQu yunmaoQu commented Jan 5, 2025

close #23809

Modifications

To address these issues, the following changes have been made:

  1. Dedicated Servlet Handler: A new servlet handler has been added specifically for the /status.html endpoint. This handler directly checks the broker's readiness state.
  2. Default statusFilePath Update: The default value for statusFilePath in standalone.conf has been changed to an empty value. This prevents the use of an invalid default path.
  3. Independence from statusFilePath: The status endpoint has been modified to operate independently of the statusFilePath configuration. This means its functionality is no longer dependent on this setting.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository

Copy link

github-actions bot commented Jan 5, 2025

@yunmaoQu Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jan 5, 2025
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't make sense at the moment. I'd prefer that @yyj8 handles the issue as I have suggested in comment #23809 (comment) instead of explaining the context to another contributor.

@yunmaoQu yunmaoQu closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] /status.html endpoint fails when statusFilePath is not set
2 participants