HDDS-12081. TestKeyInputStream repeats tests with default container layout #7704
+88
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jojochuang
reviewed
Jan 24, 2025
| scm.getContainerManager().getContainers().forEach(container -> { | ||
| if (container.isOpen()) { | ||
| try { | ||
| TestHelper.waitForContainerClose(getCluster(), container.getContainerID()); |
There was a problem hiding this comment.
I'm not sure about this.
Once open containers are closed, SCM will recreate open containers. Containers will be created using the layout specified at the DataNodes, which doesn't get updated until the start of the next test.
Wouldn't it make more sense to call closeContainers() after updateConfig()?
jojochuang
reviewed
Jan 24, 2025
|
Thanks @jojochuang for the review, good points. I have updated the patch. (I don't intend to remove usage of |
|
Merged. Thanks @adoroszlai for quick update. |
|
Thanks @jojochuang for reviewing and merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Problem:
TestChunkInputStreamandTestKeyInputStreamrepeat tests with default container layout, instead of testing with bothFILE_PER_BLOCKandFILE_PER_CHUNK.Causes:
FILE_PER_BLOCK.KeyValueHandlerdoes not allow creating containers withFILE_PER_CHUNKlayout, even if configured correctly (since HDDS-11753).Fix:
https://issues.apache.org/jira/browse/HDDS-12081
How was this patch tested?
Added temporary log in
KeyValueHandler.handleCreateContainerto show the layout being used.ozone/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java
Lines 395 to 399 in 0723902
CI:
https://github.com/adoroszlai/ozone/actions/runs/12783565176