From 200c48aab81549e9977e605bfe916c0ee373e98c Mon Sep 17 00:00:00 2001 From: Dan Wang Date: Fri, 6 Dec 2024 12:11:57 +0800 Subject: [PATCH] fix comments --- idl/utils.thrift | 2 +- src/server/pegasus_server_impl.cpp | 1 + src/utils/test/utils.cpp | 2 ++ 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/idl/utils.thrift b/idl/utils.thrift index aade69d825..659b2c5141 100644 --- a/idl/utils.thrift +++ b/idl/utils.thrift @@ -19,7 +19,7 @@ namespace cpp dsn.utils namespace go utils namespace java org.apache.pegasus.utils -// How an string matches to a given pattern. +// How a string matches to a given pattern. enum pattern_match_type { PMT_INVALID = 0, diff --git a/src/server/pegasus_server_impl.cpp b/src/server/pegasus_server_impl.cpp index 835596cd73..827748efcf 100644 --- a/src/server/pegasus_server_impl.cpp +++ b/src/server/pegasus_server_impl.cpp @@ -2338,6 +2338,7 @@ int64_t pegasus_server_impl::last_flushed_decree() const return static_cast(decree); } +// TODO(wangdan): consider using dsn::utils::pattern_match(). bool pegasus_server_impl::validate_filter(::dsn::apps::filter_type::type filter_type, const ::dsn::blob &filter_pattern, const ::dsn::blob &value) diff --git a/src/utils/test/utils.cpp b/src/utils/test/utils.cpp index b110aa3fa2..c018457e9f 100644 --- a/src/utils/test/utils.cpp +++ b/src/utils/test/utils.cpp @@ -267,6 +267,8 @@ const std::vector pattern_match_tests = { {"abc", "xyz", pattern_match_type::PMT_MATCH_ALL, ERR_OK}, // It is matched exactly. {"abc", "abc", pattern_match_type::PMT_MATCH_EXACT, ERR_OK}, + // Empty string is matched exactly with empty pattern. + {"", "", pattern_match_type::PMT_MATCH_EXACT, ERR_OK}, // Non-empty string cannot be matched exactly with empty pattern. {"abc", "", pattern_match_type::PMT_MATCH_EXACT, ERR_NOT_MATCHED}, // The string whose content is different from pattern would not be matched.