OpenAPI: Add RemoveSchemas REST update type #12022
Conversation
|
Similarly to removing unused specs, I started working on removing unused schemas. This PR is similar to #10846 |
gaborkaszab
force-pushed
the
main_rest_remove_schemas
branch
from
637f0bf to
89d177f
Compare
There was a problem hiding this comment.
@gaborkaszab I agree with this spec change, I think it's very important to maintaining table metadata sizes for cases where there's frequent schema evolution but we'll need to put this to a discuss/vote thread.
Could you send an email on the dev list? https://lists.apache.org/thread/2lo59wkhn8cm29wmokfmg2f18934qnln as an example
Thanks for taking a look, @amogh-jahagirdar ! |
|
cc @advancedxy |
open-api/rest-catalog-open-api.py
Outdated
| @@ -390,6 +390,11 @@ class RemovePartitionSpecsUpdate(BaseUpdate): | |||
| spec_ids: List[int] = Field(..., alias='spec-ids') | |||
|
|
|||
|
|
|||
| class RemoveSchemasUpdate(BaseUpdate): | |||
| action: Optional[Literal['remove-schemas']] = None | |||
There was a problem hiding this comment.
why this is optional? Looks like all other actions are constant field.
There was a problem hiding this comment.
Good catch! There have been an OpenAPI version bump since I uploaded this PR and changed the type of these updates from enum to const. As a result the generated py file no longer has the action as optional.
gaborkaszab
force-pushed
the
main_rest_remove_schemas
branch
from
89d177f to
b9d6d32
Compare
| allOf: | ||
| - $ref: '#/components/schemas/BaseUpdate' | ||
| required: | ||
| - schema-ids |
There was a problem hiding this comment.
Is there a set of updated schema ids or a set of removed schema ids? I guess the later. Just to confirm.
There was a problem hiding this comment.
Set of schemas to remove from the table by ID, I think.
There was a problem hiding this comment.
Yes this is a set of schemas to remove by ID.
| allOf: | ||
| - $ref: '#/components/schemas/BaseUpdate' | ||
| required: | ||
| - schema-ids |
There was a problem hiding this comment.
Yes this is a set of schemas to remove by ID.
No description provided.