Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataFusion Regression (Starting in v43): Type Coercion for UDF Arguments #14230

Open
Tracked by #14008
shehabgamin opened this issue Jan 22, 2025 · 1 comment · May be fixed by #14268
Open
Tracked by #14008

DataFusion Regression (Starting in v43): Type Coercion for UDF Arguments #14230

shehabgamin opened this issue Jan 22, 2025 · 1 comment · May be fixed by #14268
Assignees
@shehabgamin
Labels
bug Something isn't working

Comments

@shehabgamin
Copy link
Contributor

shehabgamin commented Jan 22, 2025 •
edited
Loading

Describe the bug

A bug was introduced in DataFusion v43.0.0 that affects type coercion for UDF arguments. Sail's tests uncovered several of these regressions, which required explicit casting in multiple areas as a workaround during the upgrade to DataFusion 43.0.0.

The regressions identified by Sail's tests include the following functions:

  1. ascii
  2. bit_length
  3. contains
  4. ends_with
  5. starts_with
  6. octet_length

Scope of Work:

  • Fix TypeSignature::Coercible.
  • Address the regressions from the list of functions above and port the relevant tests from Sail to cover these issues.

To Reproduce

No response

Expected behavior

No response

Additional context
@shehabgamin shehabgamin added the bug Something isn't working label Jan 22, 2025
@shehabgamin
Copy link
Contributor Author

Take

@shehabgamin shehabgamin mentioned this issue Jan 22, 2025
Open
31 tasks
@shehabgamin shehabgamin changed the title DataFusion Regression (Starting in v43): Coercing Various Scalar UDF Arguments to String DataFusion Regression (Starting in v43): Type Coercion for UDF Arguments Jan 25, 2025
@alamb alamb mentioned this issue Jan 25, 2025
Open
@shehabgamin shehabgamin linked a pull request Jan 26, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shehabgamin shehabgamin

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Type Coercion for UDF Arguments lakehq/datafusion
1 participant
@shehabgamin