diff --git a/bundles/cxx_remote_services/admin/src/RemoteServiceAdmin.cc b/bundles/cxx_remote_services/admin/src/RemoteServiceAdmin.cc index 962eea716..5c14b263c 100644 --- a/bundles/cxx_remote_services/admin/src/RemoteServiceAdmin.cc +++ b/bundles/cxx_remote_services/admin/src/RemoteServiceAdmin.cc @@ -115,6 +115,7 @@ void celix::rsa::RemoteServiceAdmin::removeImportedServiceFactory( importServiceFactories.erase(targetServiceName); //TODO remove imported services from this factory ??needed + //FIXME yes, it will lead to crash if we uninstall the factory: https://github.com/apache/celix/issues/653 } void celix::rsa::RemoteServiceAdmin::addExportedServiceFactory( diff --git a/bundles/cxx_remote_services/integration/gtest/src/RemoteServicesIntegrationTestSuite.cc b/bundles/cxx_remote_services/integration/gtest/src/RemoteServicesIntegrationTestSuite.cc index 69e2d5f72..f611d6666 100644 --- a/bundles/cxx_remote_services/integration/gtest/src/RemoteServicesIntegrationTestSuite.cc +++ b/bundles/cxx_remote_services/integration/gtest/src/RemoteServicesIntegrationTestSuite.cc @@ -57,8 +57,8 @@ class RemoteServicesIntegrationTestSuite : public ::testing::Test { PS_PSA_BUNDLE_LOC, PS_WIRE_BUNDLE_LOC, RS_DISCOVERY_BUNDLE_LOC, - RS_RSA_BUNDLE_LOC, - RS_FACTORY_BUNDLE_LOC }; + RS_FACTORY_BUNDLE_LOC , + RS_RSA_BUNDLE_LOC}; for (const auto& bndLoc : sharedBundles) { auto bndId = ctx->installBundle(bndLoc); EXPECT_GE(bndId, 0);