From 963f40f430e0d55b2719bb832f5120b7a2657cc1 Mon Sep 17 00:00:00 2001 From: liferoad Date: Mon, 25 Nov 2024 15:15:49 -0500 Subject: [PATCH 1/5] Fixed the new flink container precommit --- .../beam_PreCommit_Flink_Container.yml | 21 +++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/.github/workflows/beam_PreCommit_Flink_Container.yml b/.github/workflows/beam_PreCommit_Flink_Container.yml index 7b82469d2b81..2e2421b891d9 100644 --- a/.github/workflows/beam_PreCommit_Flink_Container.yml +++ b/.github/workflows/beam_PreCommit_Flink_Container.yml @@ -18,8 +18,23 @@ name: PreCommit Flink Container on: pull_request_target: paths: + - 'model/**' + - 'sdks/python/**' + - 'release/**' + - 'sdks/java/io/kafka/**' + - 'runners/core-construction-java/**' + - 'runners/core-java/**' + - 'runners/extensions-java/**' + - 'runners/flink/**' + - 'runners/java-fn-execution/**' + - 'runners/reference/**' - '.github/trigger_files/beam_PreCommit_Flink_Container.json' - 'release/trigger_all_tests.json' + push: + branches: ['master', 'release-*'] + tags: 'v*' + schedule: + - cron: '0 */6 * * *' workflow_dispatch: # Setting explicit permissions for the action to avoid the default permissions which are `write-all` @@ -66,9 +81,7 @@ jobs: github.event_name == 'workflow_dispatch' || github.event_name == 'push' || github.event_name == 'schedule' || - (github.event_name == 'pull_request_target' && - github.base_ref == 'master' && - github.event.pull_request.draft == false) || + github.event_name == 'pull_request_target' || github.event.comment.body == 'Run Flink Container PreCommit' runs-on: [self-hosted, ubuntu-20.04, main] timeout-minutes: 45 @@ -109,7 +122,7 @@ jobs: --fanout=1 \ --top_count=10 \ --iterations=1" - + # Run a Python Combine load test to verify the Flink container - name: Run Flink Container Test with Python Combine timeout-minutes: 10 From 63e6e9e564620d0a84afd19bb508fe14d490f311 Mon Sep 17 00:00:00 2001 From: liferoad Date: Mon, 25 Nov 2024 15:16:38 -0500 Subject: [PATCH 2/5] trigger it --- .github/trigger_files/beam_PreCommit_Flink_Container.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/trigger_files/beam_PreCommit_Flink_Container.json b/.github/trigger_files/beam_PreCommit_Flink_Container.json index b75e2800330d..39ca1350982f 100644 --- a/.github/trigger_files/beam_PreCommit_Flink_Container.json +++ b/.github/trigger_files/beam_PreCommit_Flink_Container.json @@ -1,4 +1,3 @@ { - "https://github.com/apache/beam/pull/33206": "testing the new flink container workflow" + "https://github.com/apache/beam/pull/33217": "testing the new flink container workflow" } - \ No newline at end of file From ba0aaadb5f7fb3bfd7acf42a62576aaaa7dfd768 Mon Sep 17 00:00:00 2001 From: liferoad Date: Mon, 25 Nov 2024 15:32:52 -0500 Subject: [PATCH 3/5] tried to trigger the workflow --- .github/trigger_files/beam_PreCommit_Flink_Container.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/trigger_files/beam_PreCommit_Flink_Container.json b/.github/trigger_files/beam_PreCommit_Flink_Container.json index 39ca1350982f..1efc8e9e4405 100644 --- a/.github/trigger_files/beam_PreCommit_Flink_Container.json +++ b/.github/trigger_files/beam_PreCommit_Flink_Container.json @@ -1,3 +1,4 @@ { - "https://github.com/apache/beam/pull/33217": "testing the new flink container workflow" + "comment": "Modify this file in a trivial way to cause this test suite to run", + "modification": 1 } From 54ff4fcaf0ceaaf4d62f1dbeffb9913aec380a68 Mon Sep 17 00:00:00 2001 From: liferoad Date: Mon, 25 Nov 2024 15:33:54 -0500 Subject: [PATCH 4/5] at least 2 workers --- .github/workflows/beam_PreCommit_Flink_Container.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/beam_PreCommit_Flink_Container.yml b/.github/workflows/beam_PreCommit_Flink_Container.yml index 2e2421b891d9..06c818286fdc 100644 --- a/.github/workflows/beam_PreCommit_Flink_Container.yml +++ b/.github/workflows/beam_PreCommit_Flink_Container.yml @@ -100,7 +100,7 @@ jobs: github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }}) - name: Start Flink with parallelism 1 env: - FLINK_NUM_WORKERS: 1 + FLINK_NUM_WORKERS: 2 run: | cd ${{ github.workspace }}/.test-infra/dataproc; ./flink_cluster.sh create # Run a simple Go Combine load test to verify the Flink container From 09c282848c6a946ddb3e27e65fc2a294ce0a9884 Mon Sep 17 00:00:00 2001 From: liferoad Date: Mon, 25 Nov 2024 15:37:07 -0500 Subject: [PATCH 5/5] trigger it --- .github/trigger_files/beam_PreCommit_Flink_Container.json | 2 +- .github/workflows/beam_PreCommit_Flink_Container.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/trigger_files/beam_PreCommit_Flink_Container.json b/.github/trigger_files/beam_PreCommit_Flink_Container.json index 1efc8e9e4405..3f63c0c9975f 100644 --- a/.github/trigger_files/beam_PreCommit_Flink_Container.json +++ b/.github/trigger_files/beam_PreCommit_Flink_Container.json @@ -1,4 +1,4 @@ { "comment": "Modify this file in a trivial way to cause this test suite to run", - "modification": 1 + "modification": 2 } diff --git a/.github/workflows/beam_PreCommit_Flink_Container.yml b/.github/workflows/beam_PreCommit_Flink_Container.yml index 06c818286fdc..42a402add966 100644 --- a/.github/workflows/beam_PreCommit_Flink_Container.yml +++ b/.github/workflows/beam_PreCommit_Flink_Container.yml @@ -98,7 +98,7 @@ jobs: comment_phrase: ${{ matrix.job_phrase }} github_token: ${{ secrets.GITHUB_TOKEN }} github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }}) - - name: Start Flink with parallelism 1 + - name: Start Flink with 2 workers env: FLINK_NUM_WORKERS: 2 run: |