Adding handling of Nulled lists to beam_row_from_dict #33830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Run Python_Dataframes PreCommit 3.12 |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
will defer to @ahmedabu98 who authored this code. |
ahmedabu98
reviewed
Feb 3, 2025
Co-authored-by: Ahmed Abualsaud <[email protected]>
|
@ahmedabu98 Added the change you suggested, thanks for that makes it cleaner. |
ahmedabu98
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Thanks for adding to the repo @TobiasBredow :)
LGTM, will merge when tests pass
tomstepp
pushed a commit
to tomstepp/apache-beam
that referenced
this pull request
Feb 3, 2025
* Adding handling of Nulled lists to beam_row_from_dict * Update sdks/python/apache_beam/io/gcp/bigquery_tools.py Co-authored-by: Ahmed Abualsaud <[email protected]> --------- Co-authored-by: Ahmed Abualsaud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #32155 and fixes the handling of missing repeated fields inside a dicts when converting a dict to a beam row. As described in the issue it matches BigQuery standard behaviour of converting Null repeated fields to empty arrays on insert.
https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#array_nulls
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.