Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some large model troubleshooting steps #31862

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

damccorm
Copy link
Contributor

This came up in a conversation with a user who had this issue


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm
Copy link
Contributor Author

R: @liferoad

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

#### Pickling errors

When sharing a model across processes with `large_model=True` or using a custom model handler, Beam sends the input and output data across a process boundary.
To do this, it uses a serialization method known as [pickling](https://docs.python.org/3/library/pickle.html).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we issue one warning about this pickling error when large_model=True is set? We could link this guide.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good idea - I'll follow up more on this when I'm back, either in this PR or a separate one

@damccorm
Copy link
Contributor Author

damccorm commented Aug 2, 2024

I'll add this in a short follow up pr to make sure we're referencing the site correctly in the error (and since this PR is approved/ready to go)

@damccorm damccorm merged commit d96fa7d into master Aug 2, 2024
5 checks passed
@damccorm damccorm deleted the users/damccorm/largeModelTroubleshooting branch August 2, 2024 15:04
@damccorm
Copy link
Contributor Author

damccorm commented Aug 2, 2024

I'll add this in a short follow up pr to make sure we're referencing the site correctly in the error (and since this PR is approved/ready to go)

#32063

reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants