Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit to prevent usage of session.query in Airflow Core #45461

Open
1 of 2 tasks
ephraimbuddy opened this issue Jan 7, 2025 · 2 comments
Open
1 of 2 tasks

Add pre-commit to prevent usage of session.query in Airflow Core #45461

ephraimbuddy opened this issue Jan 7, 2025 · 2 comments
Assignees
@Prab-27
Labels
area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code good first issue kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet

Comments

@ephraimbuddy
Copy link
Contributor

Description

We should add a pre-commit that prevents the use of session.query in airflow core. We should limit it to the source and not the tests/ package for now. The core airflow was almost rid of session.query, but the usage is gradually increasing. Adding this would require fixing all the session.query usages in the core code

Use case/motivation

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@ephraimbuddy ephraimbuddy added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Jan 7, 2025
@dosubot dosubot bot added the area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code label Jan 7, 2025
@Prab-27
Copy link
Contributor

Prab-27 commented Jan 7, 2025

@potiuk ,I'd like to work on this

@ephraimbuddy
Copy link
Contributor Author

@potiuk ,I'd like to work on this

Assigned to you @Prab-27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Prab-27 Prab-27

Labels
area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code good first issue kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet
Projects
CI / DEV ENV planned work
Status: Ready
Milestone
No milestone
Development

No branches or pull requests
3 participants
@potiuk @ephraimbuddy @Prab-27