Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port SecretsMasker log filter to Task SDK #45438

Open
kaxil opened this issue Jan 6, 2025 · 2 comments
Open

Port SecretsMasker log filter to Task SDK #45438

kaxil opened this issue Jan 6, 2025 · 2 comments

Comments

@kaxil
Copy link
Member

kaxil commented Jan 6, 2025

class SecretsMasker(logging.Filter):

@Prab-27
Copy link
Contributor

Prab-27 commented Jan 7, 2025

@kaxil I'd like to work on this issue. As I understand it, I need to implement the redact_jwt method from
airflow/sdk/log.py
instead of current methods used in this class to redact secrets from logs
Please let me know if this interpretation is correct or if there are any additional requirements .

@kaxil
Copy link
Member Author

kaxil commented Jan 7, 2025

Hi, @Prab-27. My bad, I should not have kept this issue unassigned. This issue involves porting secret_masker functionality to the Task SDK, which is part of AIP-72 and would involve making some design choices.

Since we are at a time crunch for Airflow 3.0, I am assigning it to Amogh, Ash & I since it would involve a lot of discussion. Thank you though for your willingness to pick it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants