Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: highlight color from visual selection #99

Open
amerov opened this issue Aug 30, 2018 · 2 comments
Open

Feature Request: highlight color from visual selection #99

amerov opened this issue Aug 30, 2018 · 2 comments

Comments

@amerov
Copy link

amerov commented Aug 30, 2018

Sometimes I want to see color from js or other filetypes.
Use case example:
select color from string {color: '#fa755a'} and run command :Showcolor

@joeytwiddle
Copy link

joeytwiddle commented Sep 6, 2018

Please check if this applies: #85 (comment)

If your situation might also be a situation that other developers have, we should try to add automatic support first, before looking into manual support.

That said, I can see some use for manual coloring. Strings like'#feed', '#fade', '#101' could be RGBA/RGB colours, or they could hashtags or URL anchors.

@ap ap added the enhancement label Sep 12, 2018
@ap
Copy link
Owner

ap commented Sep 12, 2018

Well, it depends.

If the idea is to have a feature to say “highlight me this bit of an otherwise non-highlighted buffer”, then yes, that’s not something I feel like writing, nor something I’d want to maintain inside this plugin.

But it would certainly make sense to have a “show me a message in this colour in the command line” command that’s completely independent of what’s going on inside any buffer, just on general principle.

And along those lines it also seems reasonable to expose the RGB conversion code from the plugin so that other people can use it to write features I’m not willing to have in the plugin itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants