feat: add parameter support to layout function #6747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis pull request introduces parameter support to the layout function in the G6 library. It modifies the layout execution process by allowing layout options to be passed as parameters, enhancing flexibility in layout configurations. The changes include updates to the layout execution logic, test cases, and examples to accommodate the new parameterized approach. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
packages/g6/src/runtime/layout.ts
Outdated
| if (!this.options) return; | ||
| const pipeline = Array.isArray(this.options) ? this.options : [this.options]; | ||
| public async postLayout(layoutOptions?: LayoutOptions) { | ||
| const executeLayoutOptions = layoutOptions ? layoutOptions : this.options; |
There was a problem hiding this comment.
The postLayout function now accepts layoutOptions as an optional parameter, which is a significant change. Ensure that all dependent functions and modules are compatible with this new parameter to avoid potential runtime errors.
Aarebecca
reviewed
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.