Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mTLS on the Client Config for HTTPS #191

Closed
skaravad opened this issue Nov 26, 2024 · 4 comments · Fixed by #195
Closed

Support mTLS on the Client Config for HTTPS #191

skaravad opened this issue Nov 26, 2024 · 4 comments · Fixed by #195
Assignees

Comments

@skaravad
Copy link

skaravad commented Nov 26, 2024

We would like to offload TLS and mTLS (client cert auth) to a reverse proxy (HTTPS only) , so in theory Piko server need not have this feature.

On the Piko Client , if the TLS config can be extended to use client cert and key , it would really improve the overall security posture of the communication.

When mTLS is enabled , we can drop any un-authorized clients connections which is better security for servers open to the internet.

@andydunstall
Copy link
Owner

@skaravad Thanks for opening, I'll aim to add this weekend

I'll add mTLS to the server too just for consistency, though will start with adding it to the agent

@skaravad
Copy link
Author

Thank you @andydunstall , really appreciate it.

@andydunstall
Copy link
Owner

andydunstall commented Nov 30, 2024

@skaravad I've added #195 and tested mTLS locally, though please confirm this works ok for you before I merge

Such as you can run piko agent http my-endpoint localhost:3000 --connect.url ... --connect.tls.cert ./client.crt --connect.tls.key ./client.key

Thanks!

@skaravad
Copy link
Author

skaravad commented Dec 1, 2024

hi @andydunstall , I was able to test the agent with mTLS , it is working as designed. Thank you so much for enabling this, it really helps to reinforce the security. Kudos to you and the contributors of this project , very simple, efficient and extensible, hope to see more features / adoption in the future.

Thank you again for enabling this feature.

@skaravad skaravad closed this as completed Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants