From 7118bccb855f4b02d610f2bad07110fdc8cffa87 Mon Sep 17 00:00:00 2001 From: Tim Vink Date: Thu, 20 Jan 2022 15:33:56 +0100 Subject: [PATCH 1/3] Quote paths in test cli commands --- tests/test_precommit.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/test_precommit.py b/tests/test_precommit.py index 35337e4..1f16735 100644 --- a/tests/test_precommit.py +++ b/tests/test_precommit.py @@ -56,14 +56,14 @@ def test_precommit_hook(tmp_path): # First pass pre-commit. Will output something like: # nb_prep (pre-commit; process notebooks)..................................Failed # - hook id: nb_prep_precommit - out = shell_output(f"pre-commit try-repo {current_dir} --verbose") + out = shell_output(f"pre-commit try-repo '{current_dir}' --verbose") assert "nb_prep (pre-commit; process notebooks).." in out assert "...Failed" in out # Add changes repo.git.add(all=True) # Second pass should succeed - out = shell_output(f"pre-commit try-repo {current_dir} --verbose") + out = shell_output(f"pre-commit try-repo '{current_dir}' --verbose") assert "nb_prep (pre-commit; process notebooks).." in out assert "...Passed" in out @@ -79,6 +79,6 @@ def test_precommit_hook(tmp_path): repo.git.add(all=True) repo.git.commit(message="add stuff", author=author) - out = shell_output(f"pre-commit try-repo {current_dir} --verbose --hook-stage post-commit") + out = shell_output(f"pre-commit try-repo '{current_dir}' --verbose --hook-stage post-commit") assert "nb_prep (post-commit; replace hash placeholder in .html filenames)...." in out assert "...Passed" in out From cb48e415e600bdeff6ccbb207bd0353e1a90bf19 Mon Sep 17 00:00:00 2001 From: Tim Vink Date: Thu, 20 Jan 2022 15:35:40 +0100 Subject: [PATCH 2/3] Run unit tests also for PRs --- .github/workflows/unit_tests.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml index c92b066..06c713d 100644 --- a/.github/workflows/unit_tests.yml +++ b/.github/workflows/unit_tests.yml @@ -4,8 +4,6 @@ on: branches: - main pull_request: - branches: - - main jobs: run: name: Run unit tests From 0b077faf3877e3f920015761b97180c69cec6c2e Mon Sep 17 00:00:00 2001 From: Tim Vink Date: Thu, 20 Jan 2022 15:37:29 +0100 Subject: [PATCH 3/3] Run unit tests also for PRs 2 --- .github/workflows/unit_tests.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml index 06c713d..117c462 100644 --- a/.github/workflows/unit_tests.yml +++ b/.github/workflows/unit_tests.yml @@ -1,9 +1,5 @@ name: Unit tests -on: - push: - branches: - - main - pull_request: +on: [push, pull_request] jobs: run: name: Run unit tests