small issues

[shikulja]

• need add some comments to dll.txt to show how it work

dlls.txt
# this is SuperWoWhook
mods\SuperWoWhook.dll
# this is nampower
#mods\nampower.dll

- commented libraries work #nampower.dll what!? fixed v7

• subdirectories do not work mods\nampower.dll

• add-dll-to-exe I would also like to load sideload-DLL.dll from a subdirectory (the path is hardcoded)

the second method - the command line is convenient for silent mode
the third way is to parse dlls.txt and look for the path here, or use toml or yaml instead of a text file

• Cannot intercept dxvk and dsoal. It would be very useful to use from own subdirectories
  (there are a lot of unnecessary files in the root of the game, the logs, cache from them)
  (dsoal-aldrv.dll dsound.dll \ dxgi.dll d3d9.dll)

# If you use dxvk (https://github.com/doitsujin/dxvk), it will be loaded by this lines
mods\dxgi\dxgi.dll
mods\dxgi\d3d9.dll

# If you use dsoal (https://github.com/ThreeDeeJay/dsoal/releases/tag/latest-c%2B%2B-rewrite), it will be loaded by this lines
mods\dsoal\dsound.dll
mods\dsoal\dsoal-aldrv.dll

(you will need to set the priority correctly, and I’m also not sure whether to attach dxgi.dll anf dsoal-aldrv.dll maybe simlinked )

[allfoxwy]

commented libraries work #nampower.dll what!?

At my end comment works.

subdirectories do not work mods\nampower.dll

I ll need some time to think on this one. Because I don't want relative path to expose files outside WoW

Cannot intercept dxvk and dsoal.

These libraries work differently than mods. They have official loader in-game. I don't have an idea to intercept them yet.

Ogasai seems cant be enjected

I ll look into it. Didn't know its existence.

[shikulja]

i comment # SuperWoWhook.dll
and in game addons say what SuperWoW loaded (SuperAPI)

[allfoxwy]

i comment # SuperWoWhook.dll and in game addons say what SuperWoW loaded (SuperAPI)

Not sure. At my end I could comment out SuperWoWhook.dll

I would release a new version soon, maybe you try it later?

[allfoxwy]

The code handles comment is in fact just a copy from VanillaFixes: hannesmann/vanillafixes#56 (comment)

I feel it's working....

[allfoxwy]

I read ogasai is a bot. I don't want to load bot.

[shikulja]

@allfoxwy no problem, it's just for compatibility. It has its own injector.
This is just a project for some good crazy coding

[shikulja]

pfui skin for addon. maybe someone need. i not add pull.req for pfui because maybe something else will change
I don’t like the xml ui, the mess of tags, and poor debugging

thirdparty-vanilla.lua

HookAddonOrVariable("UnitXP_SP3_Addon", function()

    -- Main Frame
    local frame = xpsp3Frame
    pfUI.api.StripTextures(frame, true)
    CreateBackdrop(frame, nil, nil, .75)
    CreateBackdropShadow(frame)
    frame:SetWidth(300)
    frame:SetHeight(200)

    -- Title Texture
    local titleTexture = xpsp3_title_texture
    titleTexture:ClearAllPoints()
    titleTexture:SetPoint("TOP", frame, "TOP", 0, 12)
    titleTexture:SetWidth(320)
    titleTexture:SetHeight(64)

    -- Title FontString
    local titleFontString = frame:GetChildren()
    titleFontString:ClearAllPoints()
    titleFontString:SetPoint("TOP", titleTexture, "TOP", 0, -14)

    -- Close Button
    local closeButton = xpsp3_button_close
    pfUI.api.SkinButton(closeButton)
    closeButton:ClearAllPoints()
    closeButton:SetPoint("BOTTOMRIGHT", frame, "BOTTOMRIGHT", -15, 15)
    closeButton:SetWidth(100)
    closeButton:SetHeight(24)

    -- Сheckboxes
    local checkboxes = {
      xpsp3_checkButton_modernNameplate,
      xpsp3_checkButton_notify_flashTaskbarIcon,
      xpsp3_checkButton_notify_playSystemDefaultSound,
    }
    for _, checkbox in pairs(checkboxes) do
      pfUI.api.SkinCheckbox(checkbox)
    end

    -- Tooltip
    local tooltip = xpsp3tooltip
    pfUI.api.StripTextures(tooltip, true)
    CreateBackdrop(tooltip, nil, nil, .75)
    CreateBackdropShadow(tooltip)

    -- Game Menu Button
    local gameMenuButton = GameMenuButtonXPSP3
    pfUI.api.SkinButton(gameMenuButton)
end)

[allfoxwy]

pfui skin for addon. maybe someone need. i not add pull.req for pfui because maybe something else will change I don’t like the xml ui, the mess of tags, and poor debugging

Ah thanks!

I don't know how to use the code yet. lol. I would look into it later.

I'm new to this UI thing either. I'm considering build XML with some tool like https://www.wowinterface.com/downloads/info4222-WoWUIDesigner.html

[shikulja]

@allfoxwy is it possible to add to UnitXP the ability to receive BG events to play sound on PC if a battle is found?

[allfoxwy]

is it possible to add to UnitXP the ability to receive BG events to play sound on PC if a battle is found?

I think maybe we could add UPDATE_BATTLEFIELD_STATUS to the lua addon so it would flash tarkbar icon.

I m not a big fan about playing a sound. But I would look into that either. Maybe give user a choice.

[allfoxwy]

is it possible to add to UnitXP the ability to receive BG events to play sound on PC if a battle is found?

Should be done with allfoxwy/UnitXP_SP3_Addon@e785fa6

[shikulja]

skin upd

[shikulja]

Localized_Addon_v10.zip
Addon localization.
The constructor will display variables instead of text.
Unfortunately, I don’t know any other ways to translate xml in which the text will be loaded in the constructor.

[allfoxwy]

The constructor will display variables instead of text. Unfortunately, I don’t know any other ways to translate xml in which the text will be loaded in the constructor.

I don't know other way either. I thought about localization once before but gave up.

I think you don't have to paste a zip file here. You could fork the Addon then create a pull request, that's how GitHub should work.

And about pfui skin. As far as I understand now. I can't add skin in my addon. I need ask Shagu to update pfui code to support it. However I feel I would update my addon a lot, it would be annoying to ask Shagu follow my development.

Anyway thanks for all the tips and help!

[shikulja]

skin upd

And about pfui skin.

No, I just meant that I updated the skin code, it was not a request

You could fork the Addon then create a pull request, that's how GitHub should work.

Yes, I know how pr works, I added it to the zip, just as an experiment with localization.

Anyway thanks for all the tips and help!

no problem, i just fun