Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve escaping of validation JS #841

Open
mboynes opened this issue Sep 1, 2022 · 0 comments
Open

Improve escaping of validation JS #841

mboynes opened this issue Sep 1, 2022 · 0 comments

Comments

@mboynes
Copy link
Contributor

mboynes commented Sep 1, 2022

Replace the invalid uses of esc_js() and esc_attr() in class-fieldmanager-util-validation.php, e.g. this block and this block, with more appropriate escaping procedures. The entire file warrants review for updated standards. We should perhaps consider deprecating it in favor of something more modern, ideally that doesn't depend on jQuery.

Props @natebot for noticing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant