Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BQ init script runs deletions first #46

Open
gaborvolczer opened this issue Mar 16, 2022 · 1 comment
Open

BQ init script runs deletions first #46

gaborvolczer opened this issue Mar 16, 2022 · 1 comment

Comments

@gaborvolczer
Copy link
Contributor

gaborvolczer commented Mar 16, 2022

see BigQueryExecutor.executeBQInitializatorScript
deletions and inserts are collected from the script and run parallel, deletions first, inserts after

problem is that the script might contain other queries, for example "truncate"
other problem that statements might depend on each other
I think the best solution would be to keep the original sequence and forget parallelism here. ( but to be discussed)

Related PR: https://github.com/aliz-ai/jarvis/tree/cleanup_before_trivago_intergation | https://reviewable.io/reviews/aliz-ai/jarvis/45/examples/sample_volczi/volcziTest/case1/pre/volcziTest.sql

@nbali
Copy link
Contributor

nbali commented Mar 16, 2022

if we really need parallelism, it should be done with having multiple files (queryPath) containing the initialization -> parallel execution of files, but serial execution of statements inside a file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants