Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deinit is not triggered on API - tiggers OOM in IOS (V2+V3) #44

Open
VerioN1 opened this issue Feb 12, 2025 · 2 comments
Open

deinit is not triggered on API - tiggers OOM in IOS (V2+V3) #44

VerioN1 opened this issue Feb 12, 2025 · 2 comments

Comments

@VerioN1
Copy link

VerioN1 commented Feb 12, 2025

After inspecting in memory objects of this package in XCODE , I noticed ACR doesn't pick it should release NativeVideoPlayerAPI.
Adding screen shots of my app's analysis showing me switching between pages with NativeVideoPlayer to ones without, but NativeVideoPlayerAPI is not de-initing

Image
I took this screen shot after I switched to page, after scrolling some 60 videos.

Image
Then I came back to the videos page (you can see only 7 are rendered at the same time

Image
and again to page without the videos, you can see almost everything got disposed but not the API.

those objects keep stacking up until I get oom after scrolling enough videos.

this problem is worse in V3 since all objects there are not de-initing (controller, view, etc ...)
you can use this guide to replicate this leak

Copy link

Thank you for opening this issue!

I will look into it as soon as possible. In the meantime, please review these important project updates:

Your feedback and contributions are greatly appreciated!

@albemala
Copy link
Owner

@VerioN1 thank you for reporting this issue. I've just published v 3.0.0-dev.4 with some potential fixes. would you mind testing it out and see if you still see the same issue or not? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants