[api-sources] Inconsistencies with source > custom report names

[Rykarix]

Connector Name

LinkedIn Ads v5.1.1, Facebook Marketing v3.3.26

Connector Version

LinkedIn Ads v5.1.1, Facebook Marketing v3.3.26

What step the error happened?

None

Relevant information

I've set up custom reports for the following Source Connectors.

• Bing Ads v2.8.10
• LinkedIn Ads v5.1.1
• Facebook Marketing v3.3.26
• Google Ads v3.7.10

Each of these sources has a custom defined report/query/insight. This has been named: paid_budget

For each connection, I've also set up a custom prefix in the settings: linkedinads_, facebookads_, bingads_, googleads_

These are the following outputs in the schema:

• bingads_paid_budget for Bing Ads
• googleads_paid_budget for Google Ads
• linkedin_custom_paid_budget for LinkedIn Ads
• facebookads_custompaid_budget for Facebook Marketing

Notice the naming convention for linkedin and facebook.

I did not ask you to put custom_ for linkedin, or custom for facebook.

Please fix this

Relevant log output

Contribute

• Yes, I want to contribute

[Rykarix]

Linkedin Issue location: https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-linkedin-ads/source_linkedin_ads/manifest.yaml#L1448

      components_mapping:
        - type: ComponentMappingDefinition
          field_path: ["**", "name"]
          value: "custom_{{components_values['name']}}"

Change to:

      components_mapping:
        - type: ComponentMappingDefinition
          field_path: ["**", "name"]
          value: "{{components_values['name']}}"

Facebook ads issue location: https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/source.py#L309

            stream = AdsInsights(
                api=api,
                account_ids=config.account_ids,
                name=f"Custom{insight.name}",

change to

            stream = AdsInsights(
                api=api,
                account_ids=config.account_ids,
                name=f"{insight.name}",

... probably. I've not done any research into your connector code architecture so I may be wrong

[natikgadzhi]

Generally, PRs with changes like this are welcome, but tricky.

Changing a stream name would result in a schema breaking change, meaning all Airbyte users who already have this setup would have to change how they are querying their data downstream.

You would usually sync raw data and then apply a layer of transformations to build out your dimensions / business tables, so the specific stream names should not be that important.

If you wanted to get clean naming out of Airbyte right away, the easiest path forward is prob dbt transformations.