Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ZipfileDecoder) - Create new ZipfileDecoder that takes parser to further parse a response #163

Closed
2 tasks done
pnilan opened this issue Dec 10, 2024 · 0 comments · Fixed by #169
Closed
2 tasks done
Assignees

Comments

@pnilan
Copy link
Contributor

pnilan commented Dec 10, 2024

Problem

The Events stream in source-amplitude is currently preventing the source from being fully migrated to manifest-only because it requires custom record parsing with the zipfile library. We should create a low-code component that can unzip a response and prepare it to be parsed by an underlying connector-dev-specified parser (e.g. JsonParser).

This will require creating a "Parser" class that unzips BufferIOBase object data and then leverages a specified parsers to parser the decompressed data and yields the data in the same format that the other decoders return data.

Proposed Solution

  • Create a ZipfileDecoder class
    • Class should inherit from the Parser class
    • Class should have an underlying parser

Success Criteria

  • New ZipfileDecoder in CDK
  • Implemented in source-amplitude
@pnilan pnilan changed the title feat(zip decoder) - Create new zip decoder that takes an underlying parser to decoder and parse a response feat(ZipfileDecoder) - Create new zip decoder that takes an underlying parser to decoder and parse a response Dec 10, 2024
@pnilan pnilan self-assigned this Dec 10, 2024
@pnilan pnilan changed the title feat(ZipfileDecoder) - Create new zip decoder that takes an underlying parser to decoder and parse a response feat(ZipfileDecoder) - Create new ZipfileParser that takes an inner_parser to further parse a response Jan 15, 2025
@pnilan pnilan changed the title feat(ZipfileDecoder) - Create new ZipfileParser that takes an inner_parser to further parse a response feat(ZipfileParser) - Create new ZipfileParser that takes an inner_parser to further parse a response Jan 15, 2025
@pnilan pnilan changed the title feat(ZipfileParser) - Create new ZipfileParser that takes an inner_parser to further parse a response feat(ZipfileDecoder) - Create new ZipfileDecoder that takes parser to further parse a response Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant