Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessible Heading Ranks #1095

Open
fongsean opened this issue Feb 14, 2025 · 2 comments
Open

Accessible Heading Ranks #1095

fongsean opened this issue Feb 14, 2025 · 2 comments
Assignees
@janadh
Labels
alpha Alpha version of the renderer

Comments

@fongsean
Copy link
Collaborator

All headings in the renderer should follow the guidelines:
https://www.w3.org/WAI/tutorials/page-structure/headings/#heading-ranks
@fongsean fongsean added the alpha Alpha version of the renderer label Feb 14, 2025
@brendan-cheong
Copy link

Hi @janadh

From our analysis, the following typography needs to be reviewed:

N.B. Heading ranks would need to be dynamic depending on where the renderer component sits within the parent application but we're happy if the renderer's top-level heading rank is set to H1 and adjusting the ranks where necessary through the theme variant mapping.

janadh pushed a commit that referenced this issue Feb 25, 2025
- Fix for Accessible Heading Ranks #1095
be87152 
- All headings are generated dynamically based on the elevatrion i.e nesting number. Also introduced a util function
- Removed the use of "subtitle2" and replaced with "body1" MUI style
- On the divider component, removed the "light" keyword as it is deprecated and replaced it with opacity:0.6
- updated LOCAL_DEVELOPMENT guide for docker
@janadh
Copy link
Collaborator

janadh commented Feb 25, 2025 •
edited
Loading

Hi @brendan-cheong @fongsean ,
We have applied a change and waiting to be merged into alpha. Please review when it is merged.
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janadh janadh

Labels
alpha Alpha version of the renderer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@janadh @fongsean @brendan-cheong