Automatic Sleep Timer sometimes does not enable

[chrishoage]

On Android (Samsung Tab S5e) I have the automatic sleep timer enabled and set to 10 minutes.

As the audio fades out I pause and pause to reset the timer.

Mostly the timer resets.

Sometimes the timer does not reset, instead disabled and the sleep timer does not come back on until I manually start the timer.

Is there some behavior with the automatic sleep timer I am not understanding?

Is the a setting I need to tweak?

Basically the behavior I am after in the automatic sleep timer is:

When in the auto sleep timer window always enable the sleep timer.

If paused and resumed, enable the sleep timer.
If playing a new session, enable the sleep timer.
If the sleep timer is disabled, paused, resumed, enable the sleep timer.

I want to not have to check to make sure that the sleep timer is actually enabled.

Is there a way to do this or is there a bug I am encountering?

I don't have consistent steps to reproduce this yet. I just noted that sometimes I wake up (much longer after 10 minutes) and the book is still playing.

[advplyr]

This may be a bug because what you described is exactly how it should work now

[chrishoage]

Looks like you might be on this - just in case though I was able to reproduce this behavior on my phone (not near my tablet at the moment but I assume that distinction is irrelevant).

Steps to Repo:

1. Consider current time (in this example it will be 2:20PM)
2. Ensure End Time is after Current Time (3:00PM)
3. Ensure Start Time is after End Time (10:00PM)
4. Play
5. Observe timer state (not enabled)
6. Pause
7. Change Start Time to be before Current time (2:00 PM)
8. Change End time to be before Start Time (8:00 AM)
9. Play
10. Observe timer state (enabled)

[advplyr]

Thanks for tracking this down. I may be overthinking this but this solution worked in my testing.

      // In cases where end time is before start time then we shift the time window forward or backward based on the current time.
      //   e.g. start time 22:00 and end time 06:00.
      //          If current time is less than start time (e.g. 00:30) then start time will be the previous day.
      //          If current time is greater than start time (e.g. 23:00) then end time will be the next day.
      if (endCalendar.before(startCalendar)) {
        if (currentCalendar.before(startCalendar)) { // Shift start back a day
          startCalendar.add(Calendar.DAY_OF_MONTH, -1)
        } else { // Shift end forward a day
          endCalendar.add(Calendar.DAY_OF_MONTH, 1)
        }
      }

#648

[chrishoage]

Thanks for tracking this down

Thank you for fixing it!

I may be overthinking this but this solution worked in my testing.

I think the logic might be able to be a little simpler (if you desire)

• let current datetime be now
• let end datetime be current datetime-08:00
• let start datetime be current datetime-22:00
• if current datetime is before end datetime set start datetime as current date - 1
• else set end datetime as current date + 1

Proof:

Current time is before end time and after start time

• let current datetime be 03-27-00:30
• let start datetime be 03-27-22:00
• let end datetime be 03-27-08:00
• start: 03-26-22:00 end: 03-27-08:00 current: 03-27-00:30 timer on

Current time is after end time and after start time

• let current datetime be 03-27-10:30
• let start datetime be 03-27-22:00
• let end datetime be 03-27-08:00
• start: 03-27-22:00 end: 03-28-08:00 current: 03-27-10:30 timer off

Current time is after start time and before end time

• let current datetime be 03-27-23:30
• let start datetime be 03-27-22:00
• let end datetime be 03-27-08:00
• start: 03-27-22:00 end: 03-28-08:00 current: 03-27-23:30 timer on

Start and End time are the same value

• let current datetime be 03-27-10:30
• let start datetime be 03-27-08:00
• let end datetime be 03-27-08:00
• start: 03-27-08:00 end: 03-28-08:00 current: 03-27-10:30 timer on

Current Time and Start Time are the same value

• let current datetime be 03-27-22:00
• let start datetime be 03-27-22:00
• let end datetime be 03-27-08:00
• start: 03-27-22:00 end: 03-28-08:00 current: 03-27-22:00 timer on

Current Time and End Time are the same value

• let current datetime be 03-27-08:00
• let start datetime be 03-27-22:00
• let end datetime be 03-27-08:00
• start: 03-28-22:00 end: 03-27-08:00 current: 03-27-08:00 timer off

So with this I think the logic can just be

      // In cases where current time is before end time then we shift the time window forward or backward based on the current time.
      //   e.g. start time 22:00 and end time 06:00.
      //          If current time is less than start time (e.g. 00:30) then start time will be the previous day.
      //          If current time is greater than start time (e.g. 23:00) then end time will be the next day.
      if (currentCalendar.before(endCalendar)) { // Shift start back a day
        startCalendar.add(Calendar.DAY_OF_MONTH, -1)
      } else { // Shift end forward a day
        endCalendar.add(Calendar.DAY_OF_MONTH, 1)
      }

This is of course entirely untested, so use your best judgement :)

(as an aside this seems like a really good area to unit test one day)

[advplyr]

• let current datetime be 03-27-00:30
• let start datetime be 03-27-08:00
• let end datetime be 03-27-22:00
• start: 03-26-08:00 end: 03-27-22:00 current: 03-27-00:30 timer on

I think this doesn't work when the start time is before the end time

[chrishoage]

Whoops you're right! I totally overlooked that case.