Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node@v22 punycode deprecation #704

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: node@v22 punycode deprecation #704

wants to merge 1 commit into from

Conversation

shazron
Copy link
Member

@shazron shazron commented Jan 7, 2025

fixes #679

This should update [email protected] whatwg-url sub-dep to v14 for the cli and update node-fetch usage for all other plugins.

Tested in this branch by running:

bin/run info
bin/run app dev

The punycode warning should not be printed out.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a3f4c96) to head (1a27e19).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #704   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          238       238           
  Branches        47        47           
=========================================
  Hits           238       238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node 22 has warning in every cli command (eslint error)
4 participants