Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple audit categories to be run in a single assertion #29

Open
joshmcarthur opened this issue Jan 1, 2022 · 0 comments
Open

Comments

@joshmcarthur
Copy link
Contributor

Running categories one per example is suboptimal, because it requires a full browser start up and Lighthouse run, just to pluck a different key from the result JSON.

It should be pretty simple for this library to accept a list of categories to run instead of a single one (since the 'score' args etc are kwargs, we can just accept multiple categories before grabbing the kwargs).

The invocation would look like it {expect("https://example.com").to pass_lighthouse_audit(:accessibility, :pwa, score: 85).

We might also want to consider an alternative syntax, with a hash of audit category name => expected score

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant