Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

为namespace分配node的时的一些重复代码 #51

Open
AlexStocks opened this issue Jun 7, 2018 · 4 comments
Open

为namespace分配node的时的一些重复代码 #51

AlexStocks opened this issue Jun 7, 2018 · 4 comments

Comments

@AlexStocks
Copy link

https://github.com/absolute8511/ZanRedisDB/blob/master/cluster/pdnode_coord/place_driver.go#L574 到 https://github.com/absolute8511/ZanRedisDB/blob/master/cluster/pdnode_coord/place_driver.go#L587 这段代码作用是对@ nodeNameList进行排序，但是同文件里面的getNodeNameList已经对nodeNameList按照 dc name和 node name进行了有效排序，其功能似有重复。不知理解确否？
@absolute8511
Copy link
Owner

确实如此, 可能当时有其他调用入口, 做了重复处理, 后面没有调整

@AlexStocks
Copy link
Author

我们你们把代码迁移到了github.com/youzan下面，以后是打算把这个链接作为代码主站吗？关键是这里的代码都是fork出来的，没法提交issue，这个你看怎么处理下。

@absolute8511
Copy link
Owner

还没正式对外, 可以在主站提交pr吧

@AlexStocks
Copy link
Author

如果代码已经修改完，请把修改的commit贴到这里，怎么样？

absolute8511 added a commit that referenced this issue Jul 8, 2022
@absolute8511
Merge pull request #51 from youzan/fix-raft-apply-index
fcecca4 
Fix raft apply index not continued
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@absolute8511 @AlexStocks