Trying to override Volo.Abp.Account.Public.Web.Areas.Account.Controllers.AccountController

[alexandis]

Is there an existing issue for this?

• I have searched the existing issues

Description

I am trying to resolve the issue of letting the authenticated user in in tab #2 if he is already authenticated in tab #1 of the browser.
For this, I am trying to override ABP AccountController.

Reproduction Steps

Adding this to OpenID server project:

namespace Volo.Abp.Account.Public.Web.Areas.Account.Controllers
{
    [Dependency(ReplaceServices = true)]
    [ExposeServices(typeof(AccountController))]
    public class AbxAccountAcontroller : AccountController
    {
        public AbxAccountAcontroller(SignInManager<Identity.IdentityUser> signInManager, IdentityUserManager userManager, IdentitySecurityLogManager identitySecurityLogManager, IIdentityLinkUserAppService identityLinkUserAppService, ICurrentPrincipalAccessor currentPrincipalAccessor, IOptions<IdentityOptions> identityOptions, IOptionsSnapshot<reCAPTCHAOptions> reCaptchaOptions, ISettingProvider settingProvider, IdentityDynamicClaimsPrincipalContributorCache identityDynamicClaimsPrincipalContributorCache)
            : base(signInManager, userManager, identitySecurityLogManager, identityLinkUserAppService, currentPrincipalAccessor, identityOptions, reCaptchaOptions, settingProvider, identityDynamicClaimsPrincipalContributorCache)
        {
        }

        [HttpPost]
        [Route("login")]
        public override async Task<AbpLoginResult> Login(Models.UserLoginInfo login)
        {
            base.ValidateLoginInfo(login);

            await base.ReplaceEmailToUsernameOfInputIfNeeds(login);

            if (HttpContext.User.Identity.IsAuthenticated)
            {
                // If already authenticated, return a successful login result
                return new AbpLoginResult(LoginResultType.Success);
            }

            return await base.Login(login);
        }
    }
}

Expected behavior

The class code is triggered

Actual behavior

The class code is not triggered

Regression?

No response

Known Workarounds

No response

Version

8.1.3

User Interface

Angular

Database Provider

EF Core (Default)

Tiered or separate authentication server

Separate Auth Server

Operation System

Windows (Default)

Other information

No response

[maliming]

hi

We have a ReplaceControllers attribute.

#16617

[alexandis]

I have made this:

[ReplaceControllers(typeof(AccountController))]
public class AbxAccountAcontroller : AccountController

and it is still not triggered. Do i need to do something additionally?

[maliming]

Please upload your test project to Github.

[alexandis]

@maliming OK
https://github.com/alexandis/Test/blob/b9106b13835c3e29c225750b26eb4da1a6deeca1/aspnet-core/src/Test.AuthServer/AbxAccountAcontroller.cs - this is not invoked.

[maliming]

[alexandis]

I did not check this such a way.
What I expect is this controller to be invoked when I am trying to login from Angular app (the part of the git repository, too) - but it is not.

[maliming]

Angular app use code flow to get access tokens, it will not call this controller.

https://github.com/alexandis/Test/blob/b9106b13835c3e29c225750b26eb4da1a6deeca1/angular/src/environments/environment.ts#L9