Dangerous Extension of Feature Checking.

[polatefekaya]

abp/framework/src/Volo.Abp.Features/Volo/Abp/Features/FeatureCheckerExtensions.cs

Lines 55 to 62 in dc3a6d5

	public static async Task CheckEnabledAsync(this IFeatureChecker featureChecker, string featureName)
	{
	if (!(await featureChecker.IsEnabledAsync(featureName)))
	{
	throw new AbpAuthorizationException(code: AbpFeatureErrorCodes.FeatureIsNotEnabled).WithData(
	"FeatureName", featureName);
	}
	}

I found this code while reading through the documentaion. I think the naming is vague and the lackness of comment explanation makes that method dangerous for the people who doesn't read the documentation.

Maybe a XML Comment will be useful for user to understand what that method returns.

And I don't get why this framework needs a method that throws an exception if the value is false. User can simply use IsEnabledAsync and can throw an exception based on the return value.

[maliming]

hi

This method will be used in filters or interceptions.

I will add the comment for the extension methods that will throw exceptions.

---

#21737