-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Second browser window is opening. #82
Comments
@ZurabKV Facing the same issue |
Same issue, additional consequences. I'm running a11y audits on a page generated from a form submission (POST). Because playAudit is re-loading the page itself, it does a GET to the url and loses the form context.
It's like running lighthouse in chrome in 'Navigation' mode instead of 'Snapshot'? Could this be fixed via #44 ? |
Facing the same issue, this repo seems poor maintained |
Same issue here. Sadly, this makes temporal testing impossible with Playwright which, for me, is the big selling point of LightHouse. "lighthouse": "^9.6.8", As Playwright is now the most popular test framework, it would be good to see the Lighthouse plugin maintained for this. |
Hello.
We were trying to update version of playwright-lighthouse from 2.2.2 to 4.0.0.
Older version of the package ran lighthouse audit in the same browser window and it worked well. New version of lighthouse additionally openes new browser window when running function playAudit(). Is there a way to prevent this from happening and perform the audit in the initial browser window?
New browser window doesn't have necessary cookies (and maybe some other storage data?) which causes the page to open with errors.
I found a way to pass necessary cookies to the second browser:
return playAudit({
And it did partially help to resolve the issue. Partially, because it passed all the cookies, apart from one. My guess is it is because that specific cookie contained
=
sybol inside its value, perhaps this somehow prevents the cookie to be added to the 2nd browser?The text was updated successfully, but these errors were encountered: