Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question]: do we really need playwright library or not? #56

Open
stevez opened this issue Aug 15, 2023 · 3 comments
Open

[question]: do we really need playwright library or not? #56

stevez opened this issue Aug 15, 2023 · 3 comments

Comments

@stevez
Copy link

stevez commented Aug 15, 2023

I found if I use the following code, then the playwright library can be removed:

test("Ligthouse performance test", async ({playwright}) => {
const browser = await playwright.chromium.launch({
args: ['--remote-debugging-port=9222'],
});

  const page = await browser.newPage();
  await page.goto('https://www.google.ca');

....

@abhinaba-ghosh
Copy link
Owner

Are you looking to connect the library with an existing playwright connection? If yes, we can check the possibility to do so.

@alphonse92
Copy link

Not at all, but you can open a new browser to do that. But if you want to use the same playwright browser you could add the remote debugging port into playwright configuration:

Screenshot 2024-08-06 at 10 12 54 AM

@vincerubinetti
Copy link

vincerubinetti commented Oct 29, 2024

I found that setting the --remote-debugging-port globally in the config messed up my other tests.

I'm finding when I follow the exact example in the readme, I get the following Test timeout of 30000ms exceeded. browserType.launch error on some of my Lighthouse tests, consistently.

Screenshot 2024-10-29 at 3 09 18 PM

Edit: turning off fullyParallel seemed to fix it.

Another edit: Sorry, I missed the "Using with the Playwright test-runner" part of the readme, where it shows how to support parallel runs. Not to nitpick but shouldn't this section be near the top of the readme? Isn't this what most people are using this library for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants