Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong use of settype() #40

Open
larsbo opened this issue Apr 19, 2014 · 2 comments
Open

wrong use of settype() #40

larsbo opened this issue Apr 19, 2014 · 2 comments

Comments

@larsbo
Copy link
Contributor

larsbo commented Apr 19, 2014

in the current commit the settype() function was misleadingly used in the CleanData() function. The result of settype() is not the manipulated data but a boolean result code. This results in empty inserts in many cases.
@Gummibeer
Copy link
Contributor

yeah, sorry - my fault :(
copy'n'paste from my own code where i have an error-var. thx for this correction.

@4thguy
Copy link

4thguy commented Dec 4, 2014

Pull request to fix this bug has been submitted

a1phanumeric added a commit that referenced this issue Dec 4, 2014
@a1phanumeric
Merge pull request #41 from larsbo/master
41a505b 
fix issue #40 and add full type names like 'string' and 'integer'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@larsbo @4thguy @Gummibeer