Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Create README #4

Merged
merged 7 commits into from
Feb 20, 2020
Merged

[WIP] Create README #4

merged 7 commits into from
Feb 20, 2020

Conversation

nvti
Copy link
Member

@nvti nvti commented Feb 19, 2020 •
edited
Loading

What does this MR do?

Create README

Related issues

Close #3

Author's checklist

  • Link related issues. If no related issue, create issue first.
  • Target to right branch
  • Set milestone
  • Assign to a reviewer
  • Apply label.

Review checklist

@nvti nvti added the documentation Improvements or additions to documentation label Feb 19, 2020
@nvti nvti added this to the Create project milestone Feb 19, 2020
@nvti nvti requested a review from a team February 19, 2020 03:35
@nvti
Copy link
Member Author

nvti commented Feb 19, 2020

@honghanhh đã viết xong chưa mà approve :))

@nvti nvti requested a review from a team February 19, 2020 07:16
nvti
nvti commented Feb 19, 2020
View reviewed changes
Copy link
Member Author

@nvti nvti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, but still has some mistake

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
nvti
nvti commented Feb 19, 2020
View reviewed changes
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@honghanhh @nvti
Update README.md
7f86d67 
Co-Authored-By: Viet-Tien <[email protected]>
@honghanhh
Copy link
Member

@tiena2cva is there any problem to approve the request?

@nvti nvti merged commit d1edc95 into master Feb 20, 2020
@nvti nvti deleted the update_readme branch February 20, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honghanhh honghanhh honghanhh approved these changes

Assignees

@honghanhh honghanhh

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
Create project
Development

Successfully merging this pull request may close these issues.

[DOC] Write README
2 participants
@nvti @honghanhh