Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hall of Fame times are processed locally #36

Open
sillypears opened this issue Nov 27, 2017 · 2 comments
Open

Hall of Fame times are processed locally #36

sillypears opened this issue Nov 27, 2017 · 2 comments
Labels

Comments

@sillypears
Copy link
Collaborator

Javascript renders the date locally and without an actual time (speedrun.com always uses 0800) it will change the date depending on where you are located in the world. Need to fix that by either hardcoding a time or just hardcoding the date string.

France:
image

US:
image

@sillypears sillypears added the bug label Nov 27, 2017
@sillypears sillypears self-assigned this Nov 27, 2017
@Zamiell
Copy link
Owner

Zamiell commented Nov 27, 2017

It should probably always use 0000.

@sillypears
Copy link
Collaborator Author

Yea, was thinking about it. It probably just makes more sense to hardcode this since we don't care about rendering it properly. It is currently defaulting to 0000 as far as I can tell since I don't give it a time, and thus why it's wrong for me and right for people ahead of +0000 UTC. The date is the only thing that matters (and the time isn't even capture on speedrun.com) so want it to render with the same date no matter where someone is because that was the date that it was completed for the runner.

@sillypears sillypears removed their assignment Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants