Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmarks are hard to run on Ubuntu #5

Closed
benibela opened this issue Jan 28, 2020 · 1 comment
Closed

benchmarks are hard to run on Ubuntu #5

benibela opened this issue Jan 28, 2020 · 1 comment

Comments

@benibela
Copy link

benibela commented Jan 28, 2020

Describe the bug
Benchmarks do not run

To Reproduce
Steps to reproduce the behavior:

  1. Issued pxi command.

$ make

  1. Error thrown or unexpected behavior.
for ((i=1546300800;i<=1577836799;i++)); do printf '{"time":%d}\n' $i >> data/2019-small.jsonl; done
  /bin/sh: 1: Syntax error: Bad for loop variable

here /bin/sh is dash not bash

/usr/bin/time -lp pxi 'json => json.time' < data/2019-small.jsonl > /tmp/pxi.jsonl
/usr/bin/time: invalid option -- 'l'
pxi < /tmp/mlr.jsonl | diff --brief --report-identical-files - /tmp/pxi.jsonl
Files - and /tmp/pxi.jsonl differ
make: *** [Makefile:132: json-3-mlr] Error 1

Expected behavior

Benchmarks

Desktop (please complete the following information):

  • OS: KUbuntu 19.04
  • Version (pxi --version): github
@Yord
Copy link
Owner

Yord commented Jan 28, 2020

Hi benibela,

thanks for the bug report! I must admit, the benchmarks are only really tested on MacOS at this point. This is definitely something I am planning to change, and soon. Your report shows, this should be further up on my list of priorities.

I am getting back to this issue soon.

Cheers
Yord

@Yord Yord closed this as completed Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants