Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border colors and behaviour in WordPress.org #338

Closed
beafialho opened this issue Feb 14, 2023 · 2 comments · Fixed by #350
Closed

Border colors and behaviour in WordPress.org #338

beafialho opened this issue Feb 14, 2023 · 2 comments · Fixed by #350

Comments

@beafialho
Copy link

A discussion came up on this issue regarding the header and when it should have a border vs when it shouldn't. The thinking would be, whenever the header background is the same color as the cover background, there should be a border to act as a visual mark.

The example for the header in the Hosting page:

Captura de ecrã 2023-02-14, às 15 46 06

Same for the footer.

Captura de ecrã 2023-02-14, às 15 46 57

Another example with the header and cover in black as well, there should be a white border with opacity between them.

Captura de ecrã 2023-02-14, às 15 44 56

Here's an example with coloured backgrounds:

Captura de ecrã 2023-02-14, às 15 45 41

Captura de ecrã 2023-02-14, às 15 53 31

There may be exceptions depending on the concept of the design (such as About) where separators don't have opacity, or thumbnails that could require a bit more opacity, but after a few tests I think 10% opacity for header and footer could work. What do you think @WordPress/meta-design @marko-srb?

@jasmussen
Copy link
Collaborator

The fewer exceptions the better, of course, we might even find we can do without them. But yes, sounds good.

@marko-srb
Copy link

I think having a 10% opacity there works well. Bea and I went over this issue for one additional page and it seems like a necessary element to me. Afterward, I tested various opacity lines on different pages and I think 10% works best, plus that we need that line. Hope this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants