Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not available in Vite environment #319

Open
tequdev opened this issue Aug 8, 2024 · 6 comments
Open

Not available in Vite environment #319

tequdev opened this issue Aug 8, 2024 · 6 comments

Comments

@tequdev
Copy link
Contributor

tequdev commented Aug 8, 2024

The package published or the dependency contains process code and will not work in the vite environment.
スクリーンショット 2024-08-08 21 24 56

https://vitejs.dev/guide/env-and-mode

@tequdev
Copy link
Contributor Author

tequdev commented Aug 8, 2024

It seems to be caused by assert() used in [email protected].
In 2.0.0, the assert package is no longer used.

@WietseWind
Copy link
Owner

@tequdev I'll dive in later, but for now: could it make sense to simply polyfill node process? E.g. with vite-plugin-node-polyfills

@tequdev
Copy link
Contributor Author

tequdev commented Aug 9, 2024

I thought it would be more beneficial to the user if this package itself could solve this problem, rather than all users of this package in a vite environment using that plugin.

If you decide not to take this action, I will respect your decision.

@WietseWind
Copy link
Owner

Oh I plan to take action, I was just trying to give a temp workaround for until I fix this at package level, since I'm currently on a holiday ;)

@tequdev
Copy link
Contributor Author

tequdev commented Aug 9, 2024

No hurry! Thanks.

@WietseWind
Copy link
Owner

@tequdev I just updated ripple-keypairs in this lib and the dependency libs (xrpl-sign-... and secret numbers lib):

[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants