Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing multiple whitespace between host and code #9

Open
majido opened this issue Jun 19, 2020 · 2 comments
Open

Allowing multiple whitespace between host and code #9

majido opened this issue Jun 19, 2020 · 2 comments

Comments

@majido
Copy link
Member

majido commented Jun 19, 2020

IMHO the current parsing logic is a bit too strict when handling the space between host and code:

  1. It requires exactly one SPACE
  2. It requires SPACE and not a more general whitespace which includes TAB as well.

I suggest we relax these two requirements.

A secondary but somewhat related concern the parsing logic in some places uses ASCII whitespace and in some place uses SPACE. I think it would be much easier to have a single concept of white space that we use in the whole parsing algorithm.

This could be either:

  • ASCII whitespace: which includes U+0009 TAB, U+000A LF, U+000C FF, U+000D CR, or U+0020 SPACE. One concern is that it includes LF and CR which are not relevant given that parsing is happening on a single line.
  • Custom define white space for this spec to just be: U+0020 SPACE + U+0009 TAB
@samuelgoto
Copy link
Collaborator

Seems reasonable to me. @hober WDYT?

context for @hober : this came up while code reviewing the implementation of the spec here.

@majido
Copy link
Member Author

majido commented Jul 9, 2020

Sent a PR to at least make whitespace definition consistent in parsing.

#10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants