Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: "Include child tags" option doesn't work when excluding tags #1869

Open
4 of 7 tasks
Susko3 opened this issue Dec 20, 2024 · 0 comments
Open
4 of 7 tasks

Search: "Include child tags" option doesn't work when excluding tags #1869

Susko3 opened this issue Dec 20, 2024 · 0 comments
Labels
bug/error Bugs and errors (timeout) complexity: unknown Unknown days of work content: search Search content: tags Tag entries priority: low Issues/Tasks that are not so important

Comments

@Susko3
Copy link
Collaborator

Susko3 commented Dec 20, 2024

Website (required)

VocaDB

Describe the bug (required)

Enabling Include child tags doesn't do anything when a tag is added in the Exclude filtering mode. There should be an option to include child tags in the filter when using exclude mode. Or it should be the default. See 'Expected behavior'.

To Reproduce (optional)

  1. Go to the search page for songs
  2. Show More filters
  3. Add pop tag
  4. Exclude it
  5. Enable Include child tags
  6. Set Artist filter to SOLARIA

You're now at https://vocadb.net/Search?searchType=Song&artistId%5B0%5D=76317&artistParticipationStatus=Everything&childTags=true&childVoicebanks=false&draftsOnly=false&filter=&maxLength=0&minLength=0&onlyRatedSongs=false&onlyWithPVs=false&page=1&pageSize=10&songType=Unspecified&sort=RatingScore&unifyEntryTypesAndTags=false&viewMode=Details&excludedTags%5B0%5D=341

Actual behavior

Songs that are tagged by children of the pop tag appear in the results.

Example: Dawn, which is tagged with electropop, appears in the results. And electropop → synth-pop → pop.

Expected behavior

Songs that are tagged by children of the pop tag shouldn't appear in the results. Those tags are included in the exclude filter.

Additional context (optional)

Add any other context about the problem here.

Checklist (required)

Fill out the checklist. Use strikethroughs or leave fields empty if you don't know or are unable to check/test.

@Susko3 Susko3 added the bug/error Bugs and errors (timeout) label Dec 20, 2024
@andreoda andreoda changed the title [Bug report] "Include child tags" option doesn't work when excluding tags Search: "Include child tags" option doesn't work when excluding tags Dec 22, 2024
@andreoda andreoda added content: search Search content: tags Tag entries priority: low Issues/Tasks that are not so important complexity: unknown Unknown days of work labels Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/error Bugs and errors (timeout) complexity: unknown Unknown days of work content: search Search content: tags Tag entries priority: low Issues/Tasks that are not so important
Projects
Development

No branches or pull requests

2 participants