Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log spam - Creative tab loop found when adding Block{quark:monster_box} next to Block{minecraft:spawner} #4764

Open
sciguyryan opened this issue Feb 19, 2024 · 18 comments
Assignees

Comments

@sciguyryan
Copy link

sciguyryan commented Feb 19, 2024

Hi.

While putting together a mod pack I noticed the following appearing a lot in my logs.

[18:44:05] [Render thread/WARN] [zeta/]: Creative tab loop found when adding Block{quark:monster_box} next to Block{minecraft:spawner}

It doesn't seem like it's intended to do that and something has clearly gone wrong, though nothing is amiss as far as I can see. I figured it's worth reporting just in case. If nothing else it causes a fair amount of log spam.

I've reported it here because Zeta is specifically cited in the warning, but it might be a Quark issue. I'm not certain.

@ChloeDawn
Copy link
Contributor

ChloeDawn commented Feb 22, 2024

I'm also experiencing this (seems intermittent?) and it results in entire creative tabs vanishing from the menu.
Here is a copy of my log from it occuring in my modpack: https://mclo.gs/lDVsVIk
I suspect it may be trigged from Copycats+ performing on-demand rebuilding of creative tabs for their feature config.
EDIT: I was able to reproduce without Copycats+: https://mclo.gs/Z504Kqb

@sciguyryan
Copy link
Author

Copycats+

It's definitely not Copycats+ in my case since I'm not using it in my pack. Nice to see someone else has spotted this too though!

@Krimatoria
Copy link

Krimatoria commented Mar 4, 2024

Forge 1.20.1
https://gist.github.com/Krimatoria/67b12b73a06d7c02cd86a1210a9f99fe - Log

[19:36:37] [Thread-45/WARN] [zeta/]: Creative tab loop found when adding Block{quark:monster_box} next to Block{minecraft:spawner}
java.lang.RuntimeException: Creative tab placement misses exceeded failsafe, aborting logic
at TRANSFORMER/[email protected]/org.violetmoon.zeta.registry.CreativeTabManager.buildContents(CreativeTabManager.java:141)
at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.doCastFilter(EventBus.java:260)
at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.lambda$addListener$11(EventBus.java:252)
at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.post(EventBus.java:315)
at MC-BOOTSTRAP/net.minecraftforge.eventbus/net.minecraftforge.eventbus.EventBus.post(EventBus.java:296)
at LAYER PLUGIN/[email protected]/net.minecraftforge.fml.javafmlmod.FMLModContainer.acceptEvent(FMLModContainer.java:114)
at LAYER PLUGIN/[email protected]/net.minecraftforge.fml.ModLoader.lambda$postEvent$29(ModLoader.java:326)
at java.base/java.lang.Iterable.forEach(Unknown Source)
at LAYER PLUGIN/[email protected]/net.minecraftforge.fml.ModList.forEachModInOrder(ModList.java:227)
at LAYER PLUGIN/[email protected]/net.minecraftforge.fml.ModLoader.postEvent(ModLoader.java:326)
at TRANSFORMER/[email protected]/net.minecraftforge.common.ForgeHooks.onCreativeModeTabBuildContents(ForgeHooks.java:1633)
at TRANSFORMER/[email protected]/net.minecraft.world.item.CreativeModeTab.m_269498_(CreativeModeTab.java:129)
at TRANSFORMER/[email protected]/net.minecraft.world.item.CreativeModeTabs.m_268957_(CreativeModeTabs.java:1696)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(Unknown Source)
at java.base/java.util.stream.ReferencePipeline$2$1.accept(Unknown Source)
at java.base/java.util.Iterator.forEachRemaining(Unknown Source)
at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.copyInto(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(Unknown Source)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(Unknown Source)
at java.base/java.util.stream.AbstractPipeline.evaluate(Unknown Source)
at java.base/java.util.stream.ReferencePipeline.forEach(Unknown Source)
at TRANSFORMER/[email protected]/net.minecraft.world.item.CreativeModeTabs.m_269421_(CreativeModeTabs.java:1695)
at TRANSFORMER/[email protected]/net.minecraft.world.item.CreativeModeTabs.m_269226_(CreativeModeTabs.java:1710)
at TRANSFORMER/[email protected]+1.20.1+forge/dev.emi.emi.registry.EmiStackList.reload(EmiStackList.java:62)
at TRANSFORMER/[email protected]+1.20.1+forge/dev.emi.emi.runtime.EmiReloadManager$ReloadWorker.run(EmiReloadManager.java:173)
at java.base/java.lang.Thread.run(Unknown Source)

@BigPhobos
Copy link

Also experiencing significant issues with this bug. It completely hides the contents of entire creative tabs.

@3ncanis
Copy link

3ncanis commented Mar 26, 2024

Experiencing this as well

@kaebiene
Copy link

kaebiene commented Apr 7, 2024

I think this is related to Every Compat somehow - I had the exact same error (and missing torches in JEI along with other items), and removing Every Compat solved the issue.

Needs more testing, but just in case!

Edit: Never mind, error still being thrown (but items returned)

@3ncanis
Copy link

3ncanis commented Apr 7, 2024

Seems to be just any mod that adds a lot of new items/blocks from what I can tell, if I make Supplementaries go into it's own creative tab it happens less but still occasionally does.

Vazkii referenced this issue in VazkiiMods/Zeta Apr 9, 2024
@Vazkii
Copy link
Member

Vazkii commented Apr 9, 2024

I added some debugging tools to the config. If you can still reproduce this in the next version please reach out to me on discord.

@Vazkii
Copy link
Member

Vazkii commented Apr 11, 2024

Looks like this is still happening. Version 1.0-16 should have more options to test.

I personally have never managed to reproduce this issue, so here's some points I think could be good to try and figure it out:

  • If "Force Creative Tab Appends" is enabled in the Zeta config, can the issue still happen? (This proved true in @3ncanis's instance)
  • What does the log output if "Enable Creative Verbose Logging" is enabled? (note: this will output a very large file and may crash your launcher if it's trying to pretty-print it)

Asking for anyone who can reproduce this to reach out on discord as well so we can try and track it down, thank you.

@Vazkii Vazkii pinned this issue Apr 11, 2024
@Vazkii Vazkii transferred this issue from VazkiiMods/Zeta Apr 11, 2024
@Vazkii Vazkii self-assigned this Apr 11, 2024
@MrChunks
Copy link

MrChunks commented May 8, 2024

I'm a bit new to bug reporting MC stuff, but I have the same error (on a relatively fresh ATM9 modback install, ATM9 0.2.58 )

I turned on verbose logging captured the following. I hope it's what you're looking for. I don't get an error/stacktrace, but I do get a ton of this spam:

(file attached)
logsnip.txt

It keeps on going. I can share a full log if that would help too, but maybe I'm not sharing anything useful, so I didn't want to clutter up the thread more than I already am.

@MaxWasUnavailable
Copy link

Still happening in 1.20.1 with version 1.0-19

@Krimatoria

This comment was marked as duplicate.

@DracoHero
Copy link

DracoHero commented Jul 29, 2024

I am also having this same problem today in a modpack that I am making
I attach my log: "2024-07-28-16.log"

@MaxWasUnavailable
Copy link

Still happening here.

[21Aug2024 22:56:00.630] [Server thread/ERROR] [zeta/]: Creative tab loop found when adding Block{quark:gold_button} next to Block{minecraft:stone_button}
[21Aug2024 22:56:00.630] [Server thread/ERROR] [zeta/]: For more info enable Creative Verbose Logging in the Zeta config, or set Force Creative Tab Appends to true to disable this behavior
[21Aug2024 22:56:00.630] [Server thread/ERROR] [zeta/]: Creative tab loop found when adding Block{quark:obsidian_pressure_plate} next to Block{minecraft:heavy_weighted_pressure_plate}
[21Aug2024 22:56:00.631] [Server thread/ERROR] [zeta/]: For more info enable Creative Verbose Logging in the Zeta config, or set Force Creative Tab Appends to true to disable this behavior
[21Aug2024 22:56:00.631] [Server thread/ERROR] [zeta/]: Creative tab loop found when adding Block{quark:redstone_randomizer} next to Block{minecraft:comparator}
[21Aug2024 22:56:00.631] [Server thread/ERROR] [zeta/]: For more info enable Creative Verbose Logging in the Zeta config, or set Force Creative Tab Appends to true to disable this behavior
[21Aug2024 22:56:00.631] [Server thread/ERROR] [zeta/]: Creative tab loop found when adding Block{quark:ancient_trapped_chest} next to Block{minecraft:trapped_chest}
[21Aug2024 22:56:00.631] [Server thread/ERROR] [zeta/]: For more info enable Creative Verbose Logging in the Zeta config, or set Force Creative Tab Appends to true to disable this behavior
[21Aug2024 22:56:00.631] [Server thread/ERROR] [zeta/]: Creative tab loop found when adding Block{quark:iron_button} next to Block{minecraft:stone_button}
[21Aug2024 22:56:00.631] [Server thread/ERROR] [zeta/]: For more info enable Creative Verbose Logging in the Zeta config, or set Force Creative Tab Appends to true to disable this behavior
[21Aug2024 22:56:00.631] [Server thread/ERROR] [zeta/]: Creative tab loop found when adding Block{quark:gold_button} next to Block{minecraft:stone_button}
[21Aug2024 22:56:00.631] [Server thread/ERROR] [zeta/]: For more info enable Creative Verbose Logging in the Zeta config, or set Force Creative Tab Appends to true to disable this behavior
[21Aug2024 22:56:00.631] [Server thread/ERROR] [zeta/]: Creative tab loop found when adding Block{quark:obsidian_pressure_plate} next to Block{minecraft:heavy_weighted_pressure_plate}
[21Aug2024 22:56:00.631] [Server thread/ERROR] [zeta/]: For more info enable Creative Verbose Logging in the Zeta config, or set Force Creative Tab Appends to true to disable this behavior
[21Aug2024 22:56:00.631] [Server thread/ERROR] [zeta/]: Creative tab loop found when adding Block{quark:redstone_randomizer} next to Block{minecraft:comparator}
[21Aug2024 22:56:00.631] [Server thread/ERROR] [zeta/]: For more info enable Creative Verbose Logging in the Zeta config, or set Force Creative Tab Appends to true to disable this behavior
[21Aug2024 22:56:00.631] [Server thread/ERROR] [zeta/]: Creative tab loop found when adding Block{quark:ancient_trapped_chest} next to Block{minecraft:trapped_chest}
[21Aug2024 22:56:00.631] [Server thread/ERROR] [zeta/]: For more info enable Creative Verbose Logging in the Zeta config, or set Force Creative Tab Appends to true to disable this behavior
[21Aug2024 22:56:00.632] [Server thread/ERROR] [zeta/]: Creative tab loop found when adding Block{quark:iron_button} next to Block{minecraft:stone_button}
[21Aug2024 22:56:00.632] [Server thread/ERROR] [zeta/]: For more info enable Creative Verbose Logging in the Zeta config, or set Force Creative Tab Appends to true to disable this behavior
[21Aug2024 22:56:00.635] [Server thread/ERROR] [zeta/]: Creative tab loop found when adding Block{quark:gold_button} next to Block{minecraft:stone_button}
[21Aug2024 22:56:00.635] [Server thread/ERROR] [zeta/]: For more info enable Creative Verbose Logging in the Zeta config, or set Force Creative Tab Appends to true to disable this behavior
[21Aug2024 22:56:00.635] [Server thread/ERROR] [zeta/]: Creative tab loop found when adding Block{quark:obsidian_pressure_plate} next to Block{minecraft:heavy_weighted_pressure_plate}
[21Aug2024 22:56:00.635] [Server thread/ERROR] [zeta/]: For more info enable Creative Verbose Logging in the Zeta config, or set Force Creative Tab Appends to true to disable this behavior
[21Aug2024 22:56:00.635] [Server thread/ERROR] [zeta/]: Creative tab loop found when adding Block{quark:redstone_randomizer} next to Block{minecraft:comparator}
[21Aug2024 22:56:00.635] [Server thread/ERROR] [zeta/]: For more info enable Creative Verbose Logging in the Zeta config, or set Force Creative Tab Appends to true to disable this behavior
[21Aug2024 22:56:00.635] [Server thread/ERROR] [zeta/]: Creative tab loop found when adding Block{quark:ancient_trapped_chest} next to Block{minecraft:trapped_chest}
[21Aug2024 22:56:00.635] [Server thread/ERROR] [zeta/]: For more info enable Creative Verbose Logging in the Zeta config, or set Force Creative Tab Appends to true to disable this behavior
[21Aug2024 22:56:00.635] [Server thread/ERROR] [zeta/]: Creative tab loop found when adding Block{quark:iron_button} next to Block{minecraft:stone_button}
[21Aug2024 22:56:00.635] [Server thread/ERROR] [zeta/]: For more info enable Creative Verbose Logging in the Zeta config, or set Force Creative Tab Appends to true to disable this behavior
[21Aug2024 22:56:00.635] [Server thread/ERROR] [zeta/]: Creative tab loop found when adding Block{quark:gold_button} next to Block{minecraft:stone_button}
[21Aug2024 22:56:00.635] [Server thread/ERROR] [zeta/]: For more info enable Creative Verbose Logging in the Zeta config, or set Force Creative Tab Appends to true to disable this behavior
[21Aug2024 22:56:00.635] [Server thread/ERROR] [zeta/]: Creative tab loop found when adding Block{quark:obsidian_pressure_plate} next to Block{minecraft:heavy_weighted_pressure_plate}
[21Aug2024 22:56:00.635] [Server thread/ERROR] [zeta/]: For more info enable Creative Verbose Logging in the Zeta config, or set Force Creative Tab Appends to true to disable this behavior
[21Aug2024 22:56:00.636] [Server thread/ERROR] [zeta/]: Creative tab loop found when adding Block{quark:redstone_randomizer} next to Block{minecraft:comparator}
[21Aug2024 22:56:00.636] [Server thread/ERROR] [zeta/]: For more info enable Creative Verbose Logging in the Zeta config, or set Force Creative Tab Appends to true to disable this behavior
[21Aug2024 22:56:00.636] [Server thread/ERROR] [zeta/]: Creative tab loop found when adding Block{quark:ancient_trapped_chest} next to Block{minecraft:trapped_chest}
[21Aug2024 22:56:00.636] [Server thread/ERROR] [zeta/]: For more info enable Creative Verbose Logging in the Zeta config, or set Force Creative Tab Appends to true to disable this behavior
[21Aug2024 22:56:00.636] [Server thread/ERROR] [zeta/]: Creative tab loop found when adding Block{quark:iron_button} next to Block{minecraft:stone_button}
[21Aug2024 22:56:00.636] [Server thread/ERROR] [zeta/]: For more info enable Creative Verbose Logging in the Zeta config, or set Force Creative Tab Appends to true to disable this behavior

@Krimatoria
Copy link

Krimatoria commented Sep 16, 2024

Ссылка в новом

Looks like this is still happening. Version 1.0-16 should have more options to test.

I personally have never managed to reproduce this issue, so here's some points I think could be good to try and figure it out:

  • If "Force Creative Tab Appends" is enabled in the Zeta config, can the issue still happen? (This proved true in @3ncanis's instance)
  • What does the log output if "Enable Creative Verbose Logging" is enabled? (note: this will output a very large file and may crash your launcher if it's trying to pretty-print it)

Asking for anyone who can reproduce this to reach out on discord as well so we can try and track it down, thank you.

Hello @Vazkii ) I don't know if this will help. I was looking through the log and remembered about the Zeta error that burned my log of 1200 errors, I went to this GitHub and saw your message, I turned on
image

These errors have completely stopped:

[08:26:15] [Render thread/ERROR] [zeta/]: Creative tab loop found when adding Block{quark:monster_box} next to Block{minecraft:spawner}
[08:26:15] [Render thread/ERROR] [zeta/]: For more info enable Creative Verbose Logging in the Zeta config, or set Force Creative Tab Appends to true to disable this behavior

@Veynam
Copy link

Veynam commented Nov 20, 2024

Still getting this error

@mateus3c
Copy link

I think it would be great if Quark had an option to add their own separated creative tab because from what I can tell other mods that cause this issue and don't have their own creative tab, if they have an option to add their own creative tab and the same is toggled on the mod in question stops causing this error (ex: Supplementaries)

@mateus3c
Copy link

I personally have never managed to reproduce this issue, so here's some points I think could be good to try and figure it out:

When you tried to reproduce this issue, have you tried with large modpacks? because this issue doesn't seem to happen on small modpacks, it looks like the more mods that add items directly to the vanilla creative tab you have installed bigger the chance for this issue to happen.

the issue is intermittent, and as far as I know, it only affects the redstone blocks and functional blocks creative tabs

if you join your minecraft world and the issue is not present, it won't happen during gameplay. It will only have a chance to happen again when you exit and join the same or a different world

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests