Update defaults for reading files

[datejada]

Changing the default not to skip rows when reading

Related issues

Closes #85

Checklist

• I am following the contributing guidelines
• Tests are passing
• Lint workflow is passing
• Docs were updated and workflow is passing

[datejada]

@suvayu This first change is the naive approach: updating the default and, consequently, the files and the tests.

I think you want something more robust, but I'm unsure how to do it. If you give me some hints, I can work on it.

Thanks!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.91%. Comparing base (48278bb) to head (a736ced).
Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   66.91%   66.91%           
=======================================
  Files           6        6           
  Lines         266      266           
=======================================
  Hits          178      178           
  Misses         88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[suvayu]

I don't see a better way to do this either.

What I like about it now:

1. only one (unsurprising) setting, header on/off.
2. can be easily overridden by passing ;header = false, other = val to any of the create_tbl functions, along with any other options

What I don't like: it lives in an internal pair in that module.

I won't mind it much after this PR because it doesn't do anything surprising. Previously it was by skipping lines. So it was in a way a consequence of an odd choice we made for our data files.

[suvayu]

You can actually see the consequence in your PR, removing that skip = 1 made comparing with the CSV.File(...) |> DataFrame a lot simpler.