Update online codecov requirement to 98% #849
Comments
|
This is a relevant post on this topic from the people of Codecov 😜 https://about.codecov.io/blog/the-case-against-100-code-coverage/ |
abelsiqueira
added a commit
to abelsiqueira/TulipaEnergyModel.jl
that referenced
this issue
Oct 14, 2024
Add codecov configuration file. Set 95% coverage as target for the project. Set the yellow range to 90%-95%. Closes TulipaEnergy#849
|
We discussed in person the valid coverage ranges. |
abelsiqueira
added a commit
to abelsiqueira/TulipaEnergyModel.jl
that referenced
this issue
Oct 14, 2024
Add codecov configuration file. Set 95% coverage as target for the project. Set the yellow range to 90%-95%. Closes TulipaEnergy#849
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What and Why
Local codecov is 100%, but because of JuMP if-statements we have to jerry-rig the online coverage to reach 100%.
This is silly - let's remove the jerry-rigging and set the acceptable threshold to 98% (taking after JuMP).
Coverage tests will still break if new code in a PR has lower coverage than main.
Possible Drawbacks
Slippery slope!
Related Issues
No response
The text was updated successfully, but these errors were encountered: