Specify the domain of decommission variables

[gnawin]

Pull request details

Describe the changes made in this pull request

List of related issues or pull requests

Closes #828

Collaboration confirmation

As a contributor I confirm

• I read and followed the instructions in README.dev.md
• The documentation is up to date with the changes introduced in this Pull Request (or NA)
• Tests are passing
• Lint is passing

[gnawin]

@abelsiqueira @datejada It is more or less straightforward to do this for the decommission variable of the compact method, so I did this before the refactor.

The simple method is a bit more complex because it is indexed differently, i.e., not using an indice set yet, but it will be the same idea (and the conditions are very similar as well). Since we'll refactor, I did not do it for the simple method and rather do it in the factor.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (250318e) to head (e24557a).
Report is 18 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #846   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          20       20           
  Lines        1017     1021    +4     
=======================================
+ Hits         1016     1020    +4     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gnawin]

@abelsiqueira both the link and the codecov/project fails are confusing to me, could you have a look? Thanks!

[abelsiqueira]

For completeness, repeating some thigns from the chat here.

The link check failure is probably due to changes in the treatment of automated link checkers by the end points. Recommended solution is to ignore at the moment, and check after we apply Bestie (#676). If the error persists we can add it to the ignore list. This is safe to do for this website at least. We can think again for the others.
On a side note, it is actually possible to add it to the ignore list at .markdown-link-check.json right now, but we would need to go check how to run it locally

The Codecov error is probably because version "1" points to "1.11" now (JuliaLang/www.julialang.org#2160) and that affected how the coverage is processed.
Possible solutions:

• Set a range of acceptable coverage instead of the 100% goal - it will be harder and harder to keep it at 100%, so this might be an incentive and the right time to do it
• Change the for and remove the intermediary variable constraints_files.

[abelsiqueira]

LGTM

[gnawin]

For completeness, repeating some thigns from the chat here.

The link check failure is probably due to changes in the treatment of automated link checkers by the end points. Recommended solution is to ignore at the moment, and check after we apply Bestie (#676). If the error persists we can add it to the ignore list. This is safe to do for this website at least. We can think again for the others. On a side note, it is actually possible to add it to the ignore list at .markdown-link-check.json right now, but we would need to go check how to run it locally

The Codecov error is probably because version "1" points to "1.11" now (JuliaLang/www.julialang.org#2160) and that affected how the coverage is processed. Possible solutions:

• Set a range of acceptable coverage instead of the 100% goal - it will be harder and harder to keep it at 100%, so this might be an incentive and the right time to do it
• Change the for and remove the intermediary variable constraints_files.

Edit: I will not search for a temp solution for now, because in the afternoon @datejada will apply Bestie with @abelsiqueira and will try to address this issue and the codecov issue.

After some searching, it seems that I have to use an inline comment, but it does not work

<!-- markdownlint-disable-next-line -->
[Visit this link](https://code.visualstudio.com)

Is this what I should do?