Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add objective value to multi-year test #839

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

gnawin
Copy link
Member

@gnawin gnawin commented Sep 30, 2024

Pull request details

Describe the changes made in this pull request

List of related issues or pull requests

Closes #838

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

@gnawin gnawin requested a review from abelsiqueira September 30, 2024 14:02
Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4893803) to head (acf6537).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #839   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         1021      1021           
=========================================
  Hits          1021      1021           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gnawin gnawin merged commit 4af3517 into TulipaEnergy:main Sep 30, 2024
6 checks passed
@gnawin gnawin deleted the 838-add-objective-value-to-test branch September 30, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants